You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by redink <gi...@git.apache.org> on 2013/10/21 19:30:14 UTC

thrift pull request: modified the way of exception exit for more friendly

GitHub user redink opened a pull request:

    https://github.com/apache/thrift/pull/59

    modified the way of exception exit for more friendly

    Hi:
    For the old, when the can not connect to the `Thrift Server`, it will : 
    ```
    ** exception error: no match of right hand side value {error,econnrefused}
         in function  thrift_binary_protocol:'-new_protocol_factory/2-fun-0-'/2 (src/erlang_thrift/thrift_binary_protocol.erl, line 336)
         in call from thrift_client_util:new/4 (src/erlang_thrift/thrift_client_util.erl, line 59)
    ```
    that is not very friendly. So, I modified the `thrift_binary_protocol` module.
    
    In addition,if the connection tcp closed, it will exception error via not very friendly way.
    
    Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/redink/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/59.patch

----
commit 5a07d04c11c8dd13c44915d944487f7c2342207b
Author: redink <cn...@gmail.com>
Date:   2013-10-21T17:22:29Z

    modified Erlang lib for more friendly exception exit

----