You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2017/06/12 23:59:25 UTC

[GitHub] beam pull request #3347: Check for Deferral on Non-additional inputs

GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/3347

    Check for Deferral on Non-additional inputs

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Because Side Inputs are represented within the expanded inputs, the
    check that the transform is a Combine with Side Inputs would never be
    hit. This ensures that we do not consider additional inputs during the
    check to defer evaluation of the node.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam spark_non_deferral_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3347.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3347
    
----
commit 1ac18b2eb1371422e60d50a8c3f37b3b24d59611
Author: Thomas Groh <tg...@google.com>
Date:   2017-06-12T23:55:59Z

    Check for Deferral on Non-additional inputs
    
    Because Side Inputs are represented within the expanded inputs, the
    check that the transform is a Combine with Side Inputs would never be
    hit. This ensures that we do not consider additional inputs during the
    check to defer evaluation of the node.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #3347: Check for Deferral on Non-additional inputs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/3347


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---