You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "zgxme (via GitHub)" <gi...@apache.org> on 2023/06/05 12:48:55 UTC
[GitHub] [doris] zgxme opened a new pull request, #20463: [fix](regression) fix export file case
zgxme opened a new pull request, #20463:
URL: https://github.com/apache/doris/pull/20463
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20463: [fix](regression) fix export file case
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578561339
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578113796
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20463: [fix](regression) fix export file case
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578561353
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20463: [fix](regression) fix export file case
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578598662
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] shuke987 commented on a diff in pull request #20463: [fix](regression) fix export file case
Posted by "shuke987 (via GitHub)" <gi...@apache.org>.
shuke987 commented on code in PR #20463:
URL: https://github.com/apache/doris/pull/20463#discussion_r1218839756
##########
regression-test/suites/export/test_array_export.groovy:
##########
@@ -165,9 +165,18 @@ suite("test_array_export", "export") {
} else {
throw new IllegalStateException("""${outFilePath} already exists! """)
}
- sql """
- SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFilePath}/";
+ result = sql """
+ SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFile}/";
"""
+ url = result[0][3]
+ urlHost = url.substring(8, url.indexOf("${outFile}"))
Review Comment:
can we pack scp and delete into a function( like plugin ) and call it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578641630
> @zgxme add some description please
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on a diff in pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on code in PR #20463:
URL: https://github.com/apache/doris/pull/20463#discussion_r1219108821
##########
regression-test/suites/export/test_array_export.groovy:
##########
@@ -165,9 +165,18 @@ suite("test_array_export", "export") {
} else {
throw new IllegalStateException("""${outFilePath} already exists! """)
}
- sql """
- SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFilePath}/";
+ result = sql """
+ SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFile}/";
"""
+ url = result[0][3]
+ urlHost = url.substring(8, url.indexOf("${outFile}"))
Review Comment:
> can we pack scp and delete into a function( like plugin ) and call it
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1576739407
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang merged pull request #20463: [fix](regression) fix export file case
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang merged PR #20463:
URL: https://github.com/apache/doris/pull/20463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1577063114
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xiaokang commented on pull request #20463: [fix](regression) fix export file case
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on PR #20463:
URL: https://github.com/apache/doris/pull/20463#issuecomment-1578620462
@zgxme add some description please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zgxme commented on a diff in pull request #20463: [fix](regression) fix export file case
Posted by "zgxme (via GitHub)" <gi...@apache.org>.
zgxme commented on code in PR #20463:
URL: https://github.com/apache/doris/pull/20463#discussion_r1219108209
##########
regression-test/suites/export/test_array_export.groovy:
##########
@@ -165,9 +165,18 @@ suite("test_array_export", "export") {
} else {
throw new IllegalStateException("""${outFilePath} already exists! """)
}
- sql """
- SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFilePath}/";
+ result = sql """
+ SELECT * FROM ${tableName} t ORDER BY k1 INTO OUTFILE "file://${outFile}/";
"""
+ url = result[0][3]
+ urlHost = url.substring(8, url.indexOf("${outFile}"))
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org