You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/01/28 20:45:37 UTC

[jira] Created: (HARMONY-5438) [pack200][classlib] Added some inner class support

[pack200][classlib] Added some inner class support
--------------------------------------------------

                 Key: HARMONY-5438
                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
         Environment: All pack200
            Reporter: Andrew Cornwall


I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.

This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5438) [pack200][classlib] Added some inner class support

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January reassigned HARMONY-5438:
-------------------------------------

    Assignee: Sian January

> [pack200][classlib] Added some inner class support
> --------------------------------------------------
>
>                 Key: HARMONY-5438
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, test.patch
>
>
> I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.
> This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5438) [pack200][classlib] Added some inner class support

Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Cornwall closed HARMONY-5438.
------------------------------------


> [pack200][classlib] Added some inner class support
> --------------------------------------------------
>
>                 Key: HARMONY-5438
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, test.patch
>
>
> I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.
> This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5438) [pack200][classlib] Added some inner class support

Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563574#action_12563574 ] 

Andrew Cornwall commented on HARMONY-5438:
------------------------------------------

Patch was applied correctly. Thanks!

> [pack200][classlib] Added some inner class support
> --------------------------------------------------
>
>                 Key: HARMONY-5438
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, test.patch
>
>
> I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.
> This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5438) [pack200][classlib] Added some inner class support

Posted by "Sian January (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sian January resolved HARMONY-5438.
-----------------------------------

    Resolution: Fixed

Thanks Andrew.  Patch applied at r616345.  Please check that it was applied as you expected.

> [pack200][classlib] Added some inner class support
> --------------------------------------------------
>
>                 Key: HARMONY-5438
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>            Assignee: Sian January
>         Attachments: main.patch, test.patch
>
>
> I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.
> This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5438) [pack200][classlib] Added some inner class support

Posted by "Andrew Cornwall (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Cornwall updated HARMONY-5438:
-------------------------------------

    Attachment: test.patch
                main.patch

The main.patch file adds inner class support. The test.patch file adds junit tests for the inner class support.

> [pack200][classlib] Added some inner class support
> --------------------------------------------------
>
>                 Key: HARMONY-5438
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5438
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: All pack200
>            Reporter: Andrew Cornwall
>         Attachments: main.patch, test.patch
>
>
> I've added some support for inner classes. It doesn't work completely yet, but it doesn't break anything, and since it touches code that other developers also touch, I figure it's best to get it in and visible.
> This contribution also fixes a defect in invokespecial_super and removes some obsolete code from ClassConstantPool.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.