You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by stanlyDoge <gi...@git.apache.org> on 2018/03/13 11:19:48 UTC
[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...
GitHub user stanlyDoge opened a pull request:
https://github.com/apache/activemq-artemis/pull/1952
ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1743
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1952.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1952
----
commit 555dd31f60bacbfaf15cb559c8991c1e50618367
Author: Stanislav Knot <sk...@...>
Date: 2018-03-13T11:19:01Z
ARTEMIS-1743 fix NPE in server log when Artemis trace logging is enabled
----
---
[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...
Posted by stanlyDoge <gi...@git.apache.org>.
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1952#discussion_r174094053
--- Diff: artemis-core-client/src/main/java/org/apache/activemq/artemis/core/message/impl/CoreMessage.java ---
@@ -644,8 +644,11 @@ public Message setLastValueProperty(SimpleString lastValueName) {
@Override
public int getEncodeSize() {
+ if (buffer == null) {
+ return -1;
+ }
checkEncode();
--- End diff --
checkEncode is using buffer therefore it is good to do null check before
---
[GitHub] activemq-artemis pull request #1952: ARTEMIS-1743 fix NPE in server log when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/1952
---