You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2018/09/19 09:04:40 UTC
[23/48] commons-csv git commit: [CSV-223] Inconsistency between
Javadoc of CSVFormat DEFAULT EXCEL. Apply modified patch from Samuel Martin.
Closes #26.
[CSV-223] Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL.
Apply modified patch from Samuel Martin. Closes #26.
Project: http://git-wip-us.apache.org/repos/asf/commons-csv/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-csv/commit/83cd8088
Tree: http://git-wip-us.apache.org/repos/asf/commons-csv/tree/83cd8088
Diff: http://git-wip-us.apache.org/repos/asf/commons-csv/diff/83cd8088
Branch: refs/heads/release
Commit: 83cd8088a63db894a0358e3ad5abbecc83964f3a
Parents: eede739
Author: Gary Gregory <ga...@gmail.com>
Authored: Tue Apr 3 13:45:05 2018 -0600
Committer: Gary Gregory <ga...@gmail.com>
Committed: Tue Apr 3 13:45:05 2018 -0600
----------------------------------------------------------------------
src/changes/changes.xml | 1 +
src/main/java/org/apache/commons/csv/CSVFormat.java | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-csv/blob/83cd8088/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 217c2ce..7297a18 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -43,6 +43,7 @@
<action issue="CSV-219" type="fix" dev="ggregory" due-to="Zhang Hongda">The behavior of quote char using is not similar as Excel does when the first string contains CJK char(s).</action>
<action issue="CSV-172" type="fix" dev="ggregory" due-to="Andrew Pennebaker">Don't quote cells just because they have UTF-8 encoded characters.</action>
<action issue="CSV-220" type="add" dev="ggregory" due-to="Gary Gregory">Add API org.apache.commons.csv.CSVFormat.withSystemRecordSeparator().</action>
+ <action issue="CSV-223" type="fix" dev="ggregory" due-to="Samuel Martin">Inconsistency between Javadoc of CSVFormat DEFAULT EXCEL.</action>
</release>
<release version="1.5" date="2017-09-03" description="Feature and bug fix release">
<action issue="CSV-203" type="fix" dev="ggregory" due-to="Richard Wheeldon, Kai Paroth">withNullString value is printed without quotes when QuoteMode.ALL is specified; add QuoteMode.ALL_NON_NULL. PR #17.</action>
http://git-wip-us.apache.org/repos/asf/commons-csv/blob/83cd8088/src/main/java/org/apache/commons/csv/CSVFormat.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/csv/CSVFormat.java b/src/main/java/org/apache/commons/csv/CSVFormat.java
index 10f766d..d7698ab 100644
--- a/src/main/java/org/apache/commons/csv/CSVFormat.java
+++ b/src/main/java/org/apache/commons/csv/CSVFormat.java
@@ -267,8 +267,8 @@ public final class CSVFormat implements Serializable {
* <li>{@link #withAllowMissingColumnNames(boolean) withAllowMissingColumnNames(true)}</li>
* </ul>
* <p>
- * Note: this is currently like {@link #RFC4180} plus {@link #withAllowMissingColumnNames(boolean)
- * withAllowMissingColumnNames(true)}.
+ * Note: This is currently like {@link #RFC4180} plus {@link #withAllowMissingColumnNames(boolean)
+ * withAllowMissingColumnNames(true)} and {@link #withIgnoreEmptyLines(boolean) withIgnoreEmptyLines(false)}.
* </p>
*
* @see Predefined#Excel