[GitHub] [incubator-doris] morningman commented on a change in pull request #8014: [Enhancement] Open clang compile warning option and resolve compile error Part1

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #8014:
URL: https://github.com/apache/incubator-doris/pull/8014#discussion_r805170514



##########
File path: be/src/exec/es/es_scroll_parser.cpp
##########
@@ -258,8 +256,7 @@ static Status insert_int_value(const rapidjson::Value& col, PrimitiveType type,
     return Status::OK();
 }
 
-ScrollParser::ScrollParser(bool doc_value_mode)
-        : _scroll_id(""), _size(0), _line_index(0), _doc_value_mode(doc_value_mode) {}
+ScrollParser::ScrollParser(bool doc_value_mode) : _scroll_id(""), _size(0), _line_index(0) {}

Review comment:
       `doc_value_mode` is not used?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org