You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/06 22:26:11 UTC
[GitHub] [solr] janhoy opened a new pull request #731: SOLR-15223 Limit use of org.apache.http
janhoy opened a new pull request #731:
URL: https://github.com/apache/solr/pull/731
https://issues.apache.org/jira/browse/SOLR-15223
A baby step towards getting rid of Apache Http client in solrj, removing it from three classes where it is not needed.
I was hoping that we could perhaps make the "default" solr-solr-core NOT suck in Apache Http client, only the Jetty-client, so that to use the old `HttpSolrClient` classes you'd have to add e.g. `org.apache.solr:solr-solrj-apache-http`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #731: SOLR-16088 De-couple Http2SolrClient from org.apache.http
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #731:
URL: https://github.com/apache/solr/pull/731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #731: SOLR-15223 Limit use of org.apache.http
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #731:
URL: https://github.com/apache/solr/pull/731#discussion_r820317050
##########
File path: solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java
##########
@@ -722,12 +717,12 @@ private boolean wantStream(final ResponseParser processor) {
int httpStatus = response.getStatus();
switch (httpStatus) {
- case HttpStatus.SC_OK:
- case HttpStatus.SC_BAD_REQUEST:
- case HttpStatus.SC_CONFLICT: // 409
+ case HttpStatus.OK_200:
+ case HttpStatus.BAD_REQUEST_400:
+ case HttpStatus.CONFLICT_409: // 409
Review comment:
```suggestion
case HttpStatus.CONFLICT_409:
```
nit: don't need the comment `// 409` anymore its in the constant now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #731: SOLR-15223 Limit use of org.apache.http
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #731:
URL: https://github.com/apache/solr/pull/731#discussion_r820316916
##########
File path: solr/solrj/src/java/org/apache/solr/common/util/ContentStreamBase.java
##########
@@ -47,11 +46,13 @@
public static final String DEFAULT_CHARSET = StandardCharsets.UTF_8.name();
private static final String TEXT_CSV = "text/csv";
+ public static final String TEXT_XML = "text/xml";
+ public static final String APPLICATION_OCTET_STREAM = "application/octet-stream";
+ public static final String APPLICATION_GZIP = "application/gzip";
+ public static final String APPLICATION_XML = "application/xml";
+ public static final String APPLICATION_JSON = "application/json";
Review comment:
I'm not sure all these are needed? It looks like https://www.eclipse.org/jetty/javadoc/jetty-10/org/eclipse/jetty/http/MimeTypes.Type.html has replacements for these constants?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a change in pull request #731: SOLR-15223 Limit use of org.apache.http
Posted by GitBox <gi...@apache.org>.
risdenk commented on a change in pull request #731:
URL: https://github.com/apache/solr/pull/731#discussion_r820317413
##########
File path: solr/solrj/src/java/org/apache/solr/common/util/ContentStreamBase.java
##########
@@ -47,11 +46,13 @@
public static final String DEFAULT_CHARSET = StandardCharsets.UTF_8.name();
private static final String TEXT_CSV = "text/csv";
+ public static final String TEXT_XML = "text/xml";
+ public static final String APPLICATION_OCTET_STREAM = "application/octet-stream";
+ public static final String APPLICATION_GZIP = "application/gzip";
+ public static final String APPLICATION_XML = "application/xml";
+ public static final String APPLICATION_JSON = "application/json";
Review comment:
Errr not sure tying this to Jetty is a good idea. The class is pretty generic it looks like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org