You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2010/01/06 20:36:54 UTC

[jira] Created: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
------------------------------------------------------------

                 Key: HBASE-2094
                 URL: https://issues.apache.org/jira/browse/HBASE-2094
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
             Fix For: 0.20.3


hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797337#action_12797337 ] 

Jean-Daniel Cryans commented on HBASE-2094:
-------------------------------------------

<idiotcomment> Could we just pull the needed class into our own source for 0.20?</idiotcomment>

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797338#action_12797338 ] 

stack commented on HBASE-2094:
------------------------------

Lets wait a bit on this.  Will take another look later.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797335#action_12797335 ] 

stack commented on HBASE-2094:
------------------------------

I ain't sure how to fix this.  The commons-lang addition is needed so Pair equals and hashcode works; as is its broke.  We need the fat commons-lang because it knows how to create hash codes for different types (Pair is generic so we need something that can work with its generaliity).  It then knows how to do the equals properly handling arrays of objects if passed.  I looked at pulling in pieces of commons-lang only but its hairball.  It looks like I'd end up pulling in all of commons-lang (internally they refer to each other).

Either we pull hbase-2037 -- a working comparable Pair seems pivotal to hbase-2037 -- or we expect that updating from 0.20.2 to 0.20.3, fellas need to update their MR CLASSPATHs.  I'm leaning toward the former.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797345#action_12797345 ] 

stack commented on HBASE-2094:
------------------------------

@idiot Yeah, I was on that idiot-path for a good while but commons-lang is a hairball, at least where this hashcode making and equals is concerned.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797539#action_12797539 ] 

stack commented on HBASE-2094:
------------------------------

All tests pass.  Committing.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>         Attachments: HBASE-2094.patch
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-2094.
--------------------------

    Resolution: Fixed

Committed to branch.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>         Attachments: HBASE-2094.patch
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-2094:
-------------------------

    Priority: Blocker  (was: Major)

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-2094) hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-2094:
-------------------------

    Attachment: HBASE-2094.patch

Patch that removes commons-lang from core and adds it to src/contrib/indexed/lib.  Copies whats needed from commons-lang up into Pair -- about 100 lines.

> hbase-2037 breaks mapreduce jobs going from 0.20.2 to 0.20.3
> ------------------------------------------------------------
>
>                 Key: HBASE-2094
>                 URL: https://issues.apache.org/jira/browse/HBASE-2094
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Blocker
>             Fix For: 0.20.3
>
>         Attachments: HBASE-2094.patch
>
>
> hbase-2037 makes it so commons-lang is now needed on mr classpath.  Can't have fellas having to change their CLASSPATH on point release update.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.