You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/12/06 13:50:28 UTC

zeppelin git commit: [ZEPPELIN-1747] Fix Korean notename input problem

Repository: zeppelin
Updated Branches:
  refs/heads/master 0e4d96168 -> 83320c709


[ZEPPELIN-1747] Fix Korean notename input problem

### What is this PR for?
Korean notename is incorrectly typed on Firefox.
This PR fixes the issue by changing placeholder attribute of the input field.
Getting the placeholder text from `noteName()` is unnecessary because the text is visible only when the notename is blank.

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1747

### How should this be tested?
Type Korean notename in action bar using Firefox browser.

### Screenshots (if appropriate)
![korean-notename-issue](https://cloud.githubusercontent.com/assets/17305893/20859768/d7f5cf60-b9ab-11e6-926d-814b8e0cafb3.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Sangwoo Lee <ma...@gmail.com>

Closes #1723 from marchpig/fix-korean-notename and squashes the following commits:

8ed0d15 [Sangwoo Lee] Change placeholder text
666f30c [Sangwoo Lee] Fix Korean notename input problem


Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/83320c70
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/83320c70
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/83320c70

Branch: refs/heads/master
Commit: 83320c709a6aea4663ce399abaa979a697d333d6
Parents: 0e4d961
Author: Sangwoo Lee <ma...@gmail.com>
Authored: Mon Dec 5 21:11:19 2016 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Tue Dec 6 08:50:22 2016 -0500

----------------------------------------------------------------------
 zeppelin-web/src/app/notebook/notebook-actionBar.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/zeppelin/blob/83320c70/zeppelin-web/src/app/notebook/notebook-actionBar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index 16f0e10..be57c61 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -15,7 +15,7 @@ limitations under the License.
   <h3>
     <div style="float: left; width: auto; max-width: 40%"
       ng-controller="ElasticInputCtrl as input">
-      <input type="text" pu-elastic-input class="form-control2" placeholder="{{noteName(note)}}" style="min-width: 0px; max-width: 95%;"
+      <input type="text" pu-elastic-input class="form-control2" placeholder="New name" style="min-width: 0px; max-width: 95%;"
            ng-if="input.showEditor" ng-model="note.name" ng-blur="sendNewName();input.showEditor = false;" ng-enter="sendNewName();input.showEditor = false;" ng-escape="note.name = oldName; input.showEditor = false" focus-if="input.showEditor" />
       <p class="form-control-static2" ng-click="input.showEditor = true; oldName = note.name" ng-show="!input.showEditor">{{noteName(note)}}</p>
     </div>