[GitHub] [beam] reuvenlax commented on a change in pull request #11981: [BEAM-8364] SchemaCoder is not consistent with equals

[GitBox <gi...@apache.org>]

reuvenlax commented on a change in pull request #11981:
URL: https://github.com/apache/beam/pull/11981#discussion_r442966866



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/SchemaCoder.java
##########
@@ -140,7 +140,14 @@ private void verifyDeterministic(Schema schema)
 
   @Override
   public boolean consistentWithEquals() {
-    return true;
+    // We can't guarantee that the user type T has a good equals method, so we assume the coder is
+    // not consistent with equals (BEAM-8364).
+    return false;
+  }

Review comment:
       We've generally said elsewhere that user schema types must have equalsTo defined. Should we just document that requirement?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org