You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "timveil (via GitHub)" <gi...@apache.org> on 2023/12/10 22:25:56 UTC
[I] fix instances where the number of {} placeholders in the logger message doesn't match the number of other arguments to the logging call [pinot]
timveil opened a new issue, #12132:
URL: https://github.com/apache/pinot/issues/12132
found a number of instances where the number of `{}` placeholders in the logger message doesn't match the number of other arguments to the logging call.
for example...
```
_segmentLogger.error("Illegal state {}" + _state.toString());
```
should be...
```
_segmentLogger.error("Illegal state {}", _state.toString());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] fix instances where the number of {} placeholders in the logger message doesn't match the number of other arguments to the logging call [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #12132:
URL: https://github.com/apache/pinot/issues/12132#issuecomment-1850771286
wondering if this should be captured by Checkstyle rules
for example `String.format("{}, {}", arg1, arg2, arg3)` will be captured by checkstyle rule that the arg count mismatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [I] fix instances where the number of {} placeholders in the logger message doesn't match the number of other arguments to the logging call [pinot]
Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed issue #12132: fix instances where the number of {} placeholders in the logger message doesn't match the number of other arguments to the logging call
URL: https://github.com/apache/pinot/issues/12132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org