You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by GitBox <gi...@apache.org> on 2019/05/07 08:41:31 UTC
[GitHub] [wicket] martin-g commented on a change in pull request #356:
Wicket 6662
martin-g commented on a change in pull request #356: Wicket 6662
URL: https://github.com/apache/wicket/pull/356#discussion_r281527093
##########
File path: wicket-util/src/main/java/org/apache/wicket/util/string/StringValue.java
##########
@@ -548,7 +552,14 @@ public final Double toDoubleObject() throws StringValueConversionException
*/
public final Duration toDuration() throws StringValueConversionException
{
- return Duration.valueOf(text, locale);
+ try
+ {
+ return Duration.parse(text);
+ }
+ catch (Exception e)
+ {
+ throw new StringValueConversionException("xxx", e);
Review comment:
`xxx`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services