You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Augie Fackler <du...@gmail.com> on 2007/10/03 22:59:25 UTC
[PATCH] Minor UI Consistency Nit
In my fairly extensive abuse of the svn binary while testing the
conflict resolution patch of mine that was just accepted, I noticed
that the missing log message prompt doesn't have balanced
parentheses, and that makes me sad. I noticed this because that menu
felt less aesthetically pleasing than the conflict resolution UI,
which does have balanced parens.
The attached patch (includes log message in the patch file) fixes
that so that the parentheses are balanced, just like in the conflict
resolution UI sussman wrote. As far as I can tell, this is the only
other menu-based interactive prompt, so it's the only other place
that needs to be fixed.
Peace,
Augie Fackler
Re: [PATCH] Minor UI Consistency Nit
Posted by Daniel Rall <dl...@collab.net>.
On Wed, 03 Oct 2007, Augie Fackler wrote:
> In my fairly extensive abuse of the svn binary while testing the
> conflict resolution patch of mine that was just accepted, I noticed
> that the missing log message prompt doesn't have balanced
> parentheses, and that makes me sad. I noticed this because that menu
> felt less aesthetically pleasing than the conflict resolution UI,
> which does have balanced parens.
Better yet, it feeds our collective neurosis.
> The attached patch (includes log message in the patch file) fixes
> that so that the parentheses are balanced, just like in the conflict
> resolution UI sussman wrote. As far as I can tell, this is the only
> other menu-based interactive prompt, so it's the only other place
> that needs to be fixed.
There are some other interactive prompts -- example:
(R)eject, accept (t)emporarily or accept (p)ermanently?
In any case, +1 -- committed in r26919. Thanks Augie!
- Dan