[GitHub] [incubator-iceberg] jerryshao commented on a change in pull request #657: Add list tables support in Iceberg catalog

[GitBox <gi...@apache.org>]

jerryshao commented on a change in pull request #657: Add list tables support in Iceberg catalog
URL: https://github.com/apache/incubator-iceberg/pull/657#discussion_r347696253
 
 

 ##########
 File path: api/src/main/java/org/apache/iceberg/catalog/Catalog.java
 ##########
 @@ -26,12 +26,22 @@
 import org.apache.iceberg.Transaction;
 import org.apache.iceberg.exceptions.AlreadyExistsException;
 import org.apache.iceberg.exceptions.NoSuchTableException;
+import org.apache.iceberg.exceptions.NotFoundException;
 
 /**
  * A Catalog API for table create, drop, and load operations.
  */
 public interface Catalog {
 
+  /**
+   * Return all the identifiers under this namespace.
+   *
+   * @param namespace a namespace
+   * @return an array of identifiers for tables
+   * @throws  NotFoundException if the namespace is not found
+   */
+  TableIdentifier[] listTables(Namespace namespace);
 
 Review comment:
   I don't have a strong preference on either, let me change to use `List`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org