You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/10/23 06:25:05 UTC

[GitHub] [flink] rmetzger opened a new pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

rmetzger opened a new pull request #13758:
URL: https://github.com/apache/flink/pull/13758


   ## What is the purpose of the change
   
   This PR is based on the work in #13208.
   This pull request bumps AWS SDK version to minimal version supported WebIdentityTokenCredentialsProvider in s3-fs-package, which is described in the issue.
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**yes** / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / *no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (**yes** / no / don't know)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13758:
URL: https://github.com/apache/flink/pull/13758#issuecomment-714986378


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8155",
       "triggerID" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 935ad11a8e3067394204de1df2bbb33235fc0e86 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8155) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13758:
URL: https://github.com/apache/flink/pull/13758#issuecomment-714986378


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 935ad11a8e3067394204de1df2bbb33235fc0e86 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13758:
URL: https://github.com/apache/flink/pull/13758#issuecomment-714986378


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8155",
       "triggerID" : "935ad11a8e3067394204de1df2bbb33235fc0e86",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 935ad11a8e3067394204de1df2bbb33235fc0e86 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8155) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13758:
URL: https://github.com/apache/flink/pull/13758#issuecomment-714957434


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 935ad11a8e3067394204de1df2bbb33235fc0e86 (Fri Oct 23 06:27:07 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger closed pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #13758:
URL: https://github.com/apache/flink/pull/13758


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13758:
URL: https://github.com/apache/flink/pull/13758#issuecomment-717148656


   Thanks a lot for your review. I'll address the issue and merge it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #13758: [FLINK-18676] [FileSystem] Bump s3 aws version to handle WebIdentityTokenCredentialsProvider

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #13758:
URL: https://github.com/apache/flink/pull/13758#discussion_r511934136



##########
File path: flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -8,14 +8,14 @@ This project bundles the following dependencies under the Apache Software Licens
 
 - com.amazonaws:amazon-kinesis-client:1.11.2
 - com.amazonaws:amazon-kinesis-producer:0.14.0
-- com.amazonaws:aws-java-sdk-core:1.11.754
+- com.amazonaws:aws-java-sdk-core:1.11.788
 - com.amazonaws:aws-java-sdk-dynamodb:1.11.603
-- com.amazonaws:aws-java-sdk-kinesis:1.11.754
+- com.amazonaws:aws-java-sdk-kinesis:1.11.788
 - com.amazonaws:aws-java-sdk-kms:1.11.603
 - com.amazonaws:aws-java-sdk-s3:1.11.603
-- com.amazonaws:aws-java-sdk-sts:1.11.754
+- com.amazonaws:aws-java-sdk-sts:1.11.788
 - com.amazonaws:dynamodb-streams-kinesis-adapter:1.5.0
-- com.amazonaws:jmespath-java:1.11.754
+- com.amazonaws:jmespath-java:1.11.788
 - org.apache.httpcomponents:httpclient:4.5.9
 - org.apache.httpcomponents:httpcore:4.4.6

Review comment:
       Unrelated to this PR, but this should be `4.4.11`, apparently this was broken in FLINK-19716.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org