You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/10/25 17:38:16 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8448:
Add UI-only database configuration method for extended authorization
scenarios
codecov-io edited a comment on issue #8448: Add UI-only database configuration method for extended authorization scenarios
URL: https://github.com/apache/incubator-superset/pull/8448#issuecomment-546444824
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=h1) Report
> Merging [#8448](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a39c24ef6a2456cce36035f86ef68fb6df810bda?src=pr&el=desc) will **decrease** coverage by `1.03%`.
> The diff coverage is `52.63%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8448 +/- ##
==========================================
- Coverage 67.61% 66.57% -1.04%
==========================================
Files 448 448
Lines 22486 22509 +23
Branches 2364 2364
==========================================
- Hits 15204 14986 -218
- Misses 7144 7385 +241
Partials 138 138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `81.46% <50%> (-0.47%)` | :arrow_down: |
| [superset/views/database/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvX19pbml0X18ucHk=) | `78.78% <57.14%> (-1.22%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `22.43% <0%> (-42.49%)` | :arrow_down: |
| [superset/db\_engine\_specs/pinot.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bpbm90LnB5) | `43.33% <0%> (-26.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `27.85% <0%> (-12.33%)` | :arrow_down: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `58.33% <0%> (-11.12%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `83.87% <0%> (-9.68%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `45.07% <0%> (-8.46%)` | :arrow_down: |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | `65.51% <0%> (-6.9%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `80.73% <0%> (-4.66%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/incubator-superset/pull/8448/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=footer). Last update [a39c24e...9202bd5](https://codecov.io/gh/apache/incubator-superset/pull/8448?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org