[GitHub] WillemJiang commented on a change in pull request #743: [SCB-601] when java.lang.Error: not support def type: class io.swagger.models.ComposedMode we don't know which swagger

[GitBox <gi...@apache.org>]

WillemJiang commented on a change in pull request #743: [SCB-601] when java.lang.Error: not support def type: class io.swagger.models.ComposedMode we don't know which swagger
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/743#discussion_r192278923
 
 

 ##########
 File path: swagger/swagger-generator/generator-core/src/main/java/org/apache/servicecomb/swagger/SwaggerUtils.java
 ##########
 @@ -67,6 +71,27 @@ public static Swagger parseSwagger(String swaggerContent) {
     }
   }
 
+  /**
+   * Provide a method to validate swagger. This method is now implemented to check common errors, and the logic
+   * will be changed when necessary. For internal use only.
+   */
+  public static void invalidateSwagger(Swagger swagger) {
 
 Review comment:
   the method name should be validateSwagger instead of invalidateSwagger.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services