You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/06/12 14:02:46 UTC

Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-6098
    https://issues.apache.org/jira/browse/AMBARI-6098


Repository: ambari


Description
-------

On SUSE, HostCleanup.py script don't work.  
Here is an output of it:

    
    
    
    python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
    ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

The file itself is:  
**/var/lib/ambari-agent/data/hostcleanup.result**
    
    
    
    2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

This script was run was run with cluster (ambari-server/agent installed).  
For example:

    
    
    
    rpm -qa|grep hadoop
    hadoop-libhdfs-2.2.0.2.0.6.0-102
    hadoop-client-2.2.0.2.0.6.0-102
    teradata-hadoop-builder-1.3.80.27-1
    hadoop-hdfs-2.2.0.2.0.6.0-102
    hadoop-lzo-0.5.0-1
    hadoop-mapreduce-2.2.0.2.0.6.0-102
    hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
    teradata-hadoop-tools-1.3.50.26-1
    hadoop-2.2.0.2.0.6.0-102
    hadoop-lzo-native-0.5.0-1
    hadoop-yarn-2.2.0.2.0.6.0-102
    

After ambari-server reset and going to Hosts Confirmation page Hosts warnings
were only about process, not about packets, users, files etc...  
See screenshot attached


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 

Diff: https://reviews.apache.org/r/22509/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review45494
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On June 12, 2014, 1:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 1:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review46093
-----------------------------------------------------------

Ship it!


Ship It!

- Sumit Mohanty


On June 18, 2014, 2:39 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:39 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Andrew Onischuk <ao...@hortonworks.com>.

> On June 18, 2014, 4:49 p.m., Sumit Mohanty wrote:
> > ambari-agent/src/main/python/ambari_agent/HostCleanup.py, line 23
> > <https://reviews.apache.org/r/22509/diff/2/?file=612328#file612328line23>
> >
> >     Is this hard-coding to 2.6 safe? Other changes look good.

Yes, Summit this path is hardcoded evrywhere, in pom.xml as well, and used on python 2.4/2.6/2.7 anyways.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review46091
-----------------------------------------------------------


On June 18, 2014, 2:39 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:39 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review46091
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/HostCleanup.py
<https://reviews.apache.org/r/22509/#comment81247>

    Is this hard-coding to 2.6 safe? Other changes look good.


- Sumit Mohanty


On June 18, 2014, 2:39 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 2:39 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/
-----------------------------------------------------------

(Updated June 18, 2014, 2:39 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Bugs: AMBARI-6098
    https://issues.apache.org/jira/browse/AMBARI-6098


Repository: ambari


Description
-------

On SUSE, HostCleanup.py script don't work.  
Here is an output of it:

    
    
    
    python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
    ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

The file itself is:  
**/var/lib/ambari-agent/data/hostcleanup.result**
    
    
    
    2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

This script was run was run with cluster (ambari-server/agent installed).  
For example:

    
    
    
    rpm -qa|grep hadoop
    hadoop-libhdfs-2.2.0.2.0.6.0-102
    hadoop-client-2.2.0.2.0.6.0-102
    teradata-hadoop-builder-1.3.80.27-1
    hadoop-hdfs-2.2.0.2.0.6.0-102
    hadoop-lzo-0.5.0-1
    hadoop-mapreduce-2.2.0.2.0.6.0-102
    hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
    teradata-hadoop-tools-1.3.50.26-1
    hadoop-2.2.0.2.0.6.0-102
    hadoop-lzo-native-0.5.0-1
    hadoop-yarn-2.2.0.2.0.6.0-102
    

After ambari-server reset and going to Hosts Confirmation page Hosts warnings
were only about process, not about packets, users, files etc...  
See screenshot attached


Diffs (updated)
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 

Diff: https://reviews.apache.org/r/22509/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Dmytro Shkvyra <ds...@hortonworks.com>.

> On June 17, 2014, 4:16 p.m., Sumit Mohanty wrote:
> > ambari-agent/src/main/python/ambari_agent/HostInfo.py, line 326
> > <https://reviews.apache.org/r/22509/diff/1/?file=608090#file608090line326>
> >
> >     I do not believe Suse check actually works the way check works for rhel. We need to ensure that all checks are functional. If I remember correctly, the package check was not reliable.

I have tested it, seems to package check is ok. Anyway it is should be anothes ticket.


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review45951
-----------------------------------------------------------


On June 12, 2014, 1:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 1:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review45951
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/HostInfo.py
<https://reviews.apache.org/r/22509/#comment81070>

    I do not believe Suse check actually works the way check works for rhel. We need to ensure that all checks are functional. If I remember correctly, the package check was not reliable. 



ambari-agent/src/main/python/ambari_agent/HostInfo.py
<https://reviews.apache.org/r/22509/#comment81067>

    This is not correct. The file is written only when actual host check is performed and that is done only prior to host components being mapped. There is no point writing this file when host cleanup cannot be done.


- Sumit Mohanty


On June 12, 2014, 1:57 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 1:57 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/
-----------------------------------------------------------

(Updated June 12, 2014, 1:57 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Sumit Mohanty.


Bugs: AMBARI-6098
    https://issues.apache.org/jira/browse/AMBARI-6098


Repository: ambari


Description
-------

On SUSE, HostCleanup.py script don't work.  
Here is an output of it:

    
    
    
    python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
    ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

The file itself is:  
**/var/lib/ambari-agent/data/hostcleanup.result**
    
    
    
    2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
    2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
    

This script was run was run with cluster (ambari-server/agent installed).  
For example:

    
    
    
    rpm -qa|grep hadoop
    hadoop-libhdfs-2.2.0.2.0.6.0-102
    hadoop-client-2.2.0.2.0.6.0-102
    teradata-hadoop-builder-1.3.80.27-1
    hadoop-hdfs-2.2.0.2.0.6.0-102
    hadoop-lzo-0.5.0-1
    hadoop-mapreduce-2.2.0.2.0.6.0-102
    hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
    teradata-hadoop-tools-1.3.50.26-1
    hadoop-2.2.0.2.0.6.0-102
    hadoop-lzo-native-0.5.0-1
    hadoop-yarn-2.2.0.2.0.6.0-102
    

After ambari-server reset and going to Hosts Confirmation page Hosts warnings
were only about process, not about packets, users, files etc...  
See screenshot attached


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
  ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
  ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 

Diff: https://reviews.apache.org/r/22509/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 22509: HostCleanup.py doesn't cleanup host on SUSE

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22509/#review45489
-----------------------------------------------------------



ambari-agent/src/main/python/ambari_agent/HostInfo.py
<https://reviews.apache.org/r/22509/#comment80339>

    This change will break AMBARI-3189. Please ask Sumit to review


- Dmitro Lisnichenko


On June 12, 2014, 12:02 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22509/
> -----------------------------------------------------------
> 
> (Updated June 12, 2014, 12:02 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-6098
>     https://issues.apache.org/jira/browse/AMBARI-6098
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> On SUSE, HostCleanup.py script don't work.  
> Here is an output of it:
> 
>     
>     
>     
>     python /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py --silent --skip=""
>     ERROR:HostCleanup:Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     INFO:HostCleanup:Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> The file itself is:  
> **/var/lib/ambari-agent/data/hostcleanup.result**
>     
>     
>     
>     2014-02-12 17:51:36,354 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:51:36,367 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 17:53:24,183 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 17:53:24,183 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:01:13,492 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:01:13,492 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     2014-02-12 18:02:18,787 ERROR Host check result not found at: /var/lib/ambari-agent/data/hostcheck.result
>     2014-02-12 18:02:18,787 INFO Clean-up completed. The output is at /var/lib/ambari-agent/data/hostcleanup.result
>     
> 
> This script was run was run with cluster (ambari-server/agent installed).  
> For example:
> 
>     
>     
>     
>     rpm -qa|grep hadoop
>     hadoop-libhdfs-2.2.0.2.0.6.0-102
>     hadoop-client-2.2.0.2.0.6.0-102
>     teradata-hadoop-builder-1.3.80.27-1
>     hadoop-hdfs-2.2.0.2.0.6.0-102
>     hadoop-lzo-0.5.0-1
>     hadoop-mapreduce-2.2.0.2.0.6.0-102
>     hadoop-yarn-nodemanager-2.2.0.2.0.6.0-102
>     teradata-hadoop-tools-1.3.50.26-1
>     hadoop-2.2.0.2.0.6.0-102
>     hadoop-lzo-native-0.5.0-1
>     hadoop-yarn-2.2.0.2.0.6.0-102
>     
> 
> After ambari-server reset and going to Hosts Confirmation page Hosts warnings
> were only about process, not about packets, users, files etc...  
> See screenshot attached
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 13f9d34 
>   ambari-agent/src/main/python/ambari_agent/HostInfo.py 339f21f 
>   ambari-agent/src/test/python/ambari_agent/TestHostInfo.py 05ddd9f 
> 
> Diff: https://reviews.apache.org/r/22509/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>