You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/19 05:52:39 UTC
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #6977: Introduce messages fence mechanism for Key_Shared subscription
Huanli-Meng commented on a change in pull request #6977:
URL: https://github.com/apache/pulsar/pull/6977#discussion_r427045024
##########
File path: site2/docs/reference-configuration.md
##########
@@ -144,6 +144,8 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+|subscriptionKeySharedEnable| Enable Key_Shared subscription |true|
Review comment:
```suggestion
|subscriptionKeySharedEnable| Enable Key_Shared subscription. |true|
```
##########
File path: site2/docs/reference-configuration.md
##########
@@ -144,6 +144,8 @@ Pulsar brokers are responsible for handling incoming messages from producers, di
|statusFilePath| Path for the file used to determine the rotation status for the broker when responding to service discovery health checks ||
|preferLaterVersions| If true, (and ModularLoadManagerImpl is being used), the load manager will attempt to use only brokers running the latest software version (to minimize impact to bundles) |false|
|maxNumPartitionsPerPartitionedTopic|Max number of partitions per partitioned topic. Use 0 or negative number to disable the check|0|
+|subscriptionKeySharedEnable| Enable Key_Shared subscription |true|
+|maxFencedMessagesForKeySharedSubscription| Max fenced messages for Key_Shared subscription. Messages for the new consumer will be fenced until the previous messages are acknowledged |10000|
Review comment:
```suggestion
|maxFencedMessagesForKeySharedSubscription| Set the maximum number of fenced messages for Key_Shared subscription. Messages for a new consumer are fenced until the previous messages are acknowledged. |10000|
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org