[GitHub] [incubator-druid] donbowman commented on a change in pull request #7296: Remove mysql database connector from container image

[GitBox <gi...@apache.org>]

donbowman commented on a change in pull request #7296: Remove mysql database connector from container image
URL: https://github.com/apache/incubator-druid/pull/7296#discussion_r267004774
 
 

 ##########
 File path: distribution/docker/README.md
 ##########
 @@ -24,3 +24,15 @@ From the root of the repo, run `docker build -t druid:tag -f distribution/docker
 ## Run
 
 Edit `environment` to suite. Run 'docker-compose -f distribution/docker/docker-compose.yml up`
+
+## mysql database connector
+
+This image contains solely the postgres metadata database connector. If you need
+the mysql metadata storage connector, consider adding these lines before the `addgroup`
 
 Review comment:
   I don't think this is worth doing. Nonetheless I've added it
   
   most people want the built image from the repo.
   
   for those that don't, they may want other changes in here, or different version. I think what is here satisfies most, e.g. the instructions are there, and the docker image will get built and published (which is the main goal).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org