[I] converters/orionbelt fixture declares date_dim.d_month_name, which is not a TPC-DS column [ossie]

["venkata-chikkam (via GitHub)" <gi...@apache.org>]

venkata-chikkam opened a new issue, #358:
URL: https://github.com/apache/ossie/issues/358

   `converters/orionbelt/tests/fixtures/tpcds_osi.yaml` declares a field:
   
   ```yaml
   - name: d_month_name
   ```
   
   on the `date_dim` dataset. TPC-DS has no such column. The real ones are `d_moy` (month of year),
   `d_month_seq`, and `d_current_month` — there is no month-*name* column in the schema at all.
   
   ## How it was found
   
   We're building a DuckDB implementation that *executes* Ossie models rather than converting them, so we
   can run every metric against every dimension and diff the results against hand-written TPC-DS SQL.
   Doing that at `sf=1` produced:
   
   ```
   Binder Error: Referenced column "d_month_name" not found in FROM clause!
   Candidate bindings: "d_month_seq"
   ```
   
   Our own fixtures had inherited the same mistake from the same source, and we've corrected ours to
   `d_moy`. Yours is left untouched, since it is your file.
   
   ## Why it survives in a converter test suite
   
   Nothing in a conversion round-trip touches the physical table, so a field naming a column that does
   not exist converts perfectly and never fails. It only shows up when something tries to *run* a query
   that groups by it.
   
   That is not a criticism of the fixture so much as an observation that execution catches a class of
   error conversion cannot, and it may be worth keeping in mind for the `compliance/` suite.
   
   Suggested fix is a one-line rename to `d_moy`, or dropping the field. Happy to send the PR if useful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] converters/orionbelt fixture declares date_dim.d_month_name, which is not a TPC-DS column [ossie]

["jbonofre (via GitHub)" <gi...@apache.org>]

jbonofre closed issue #358: converters/orionbelt fixture declares date_dim.d_month_name, which is not a TPC-DS column
URL: https://github.com/apache/ossie/issues/358


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org