You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/01 23:29:35 UTC
[GitHub] [lucene-solr] jtibshirani opened a new pull request #1817: Improve how Asserting* classes handle singleton doc values.
jtibshirani opened a new pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817
Some queries use DocValues.unwrapSingleton to execute different logic for
single-valued doc values. When tests use an AssertingLeafReader, unwrapSingleton
will never unwrap the doc values, as they don't have the expected class. So some
queries have code paths that are never exercised with an AssertingLeafReader.
This change makes sure to preserve the expected classes when creating asserting
doc values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685192326
I noticed this when debugging a bad bug in `IndexSortSortedNumericDocValuesRangeQuery` that wasn't caught by tests. As a follow-up I plan to make at least one more testing fix, and also fix `IndexSortSortedNumericDocValuesRangeQuery` itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani edited a comment on pull request #1817: Improve how Asserting* classes handle singleton doc values.
Posted by GitBox <gi...@apache.org>.
jtibshirani edited a comment on pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685192326
I noticed this when debugging a bad bug in `IndexSortSortedNumericDocValuesRangeQuery` that wasn't caught by tests (LUCENE-9501). As a follow-up I plan to make at least one more testing fix, and also fix `IndexSortSortedNumericDocValuesRangeQuery` itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jtibshirani commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685981921
Thanks for the review. Let me know if I should add a changelog entry or issue number (I wasn't sure what to do for smaller test fixes like this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1817: Improve how Asserting* classes handle singleton doc values.
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817#issuecomment-685989419
Good question. The test framework is used by our users so I think it makes sense to mention this change in the changelog.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jpountz merged pull request #1817: Improve how Asserting* classes handle singleton doc values.
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #1817:
URL: https://github.com/apache/lucene-solr/pull/1817
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org