[GitHub] [beam] chamikaramj commented on a diff in pull request #28039: Better manage transform service lifecycle for tests

["chamikaramj (via GitHub)" <gi...@apache.org>]

chamikaramj commented on code in PR #28039:
URL: https://github.com/apache/beam/pull/28039#discussion_r1298870799


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2807,9 +2810,17 @@ class BeamModulePlugin implements Plugin<Project> {
         throw new GradleException(exceptionMessage)
       }
 
+      // Transform service delivers transforms that refer to SDK harness containers with following sufixes.
+      def transformServiceJavaContainerSuffix = 'java11'

Review Comment:
   So this setup method is (or rather will be) shared by PythonFromJava and JavaFromPython tests.
   
   For external transforms, Transform Service will require Python3.8 and Java11 containers (transformServicePythonContainerSuffix and transformServiceJavaContainerSuffix).
   
   The pipeline SDK, we could run tests with multiple Java and Python versions hence we have to build such containers based on the test ( pythonContainerSuffix and javaContainerSuffix).
   
   For example, currently BT test is run using Python3.8 and 3.11 for pipeline SDK and Java 11 for external SDK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org