You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sk...@apache.org on 2009/07/21 09:29:03 UTC
svn commit: r796170 - in
/myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow:
FlowHandler.java config/FlowReturnAccept.java
Author: skitching
Date: Tue Jul 21 07:29:02 2009
New Revision: 796170
URL: http://svn.apache.org/viewvc?rev=796170&view=rev
Log:
Add comments only
Modified:
myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/FlowHandler.java
myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/config/FlowReturnAccept.java
Modified: myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/FlowHandler.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/FlowHandler.java?rev=796170&r1=796169&r2=796170&view=diff
==============================================================================
--- myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/FlowHandler.java (original)
+++ myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/FlowHandler.java Tue Jul 21 07:29:02 2009
@@ -288,6 +288,10 @@
cm.removeAndInvalidateConversationContext(ctx);
// Now restore the view tree of the caller.
+ //
+ // WARNING: this approach means that any "binding" attributes on the components
+ // being restored are not run. If a binding to a request-scope attribute exists,
+ // then it will be null during the following render phase :-(
restoreViewRoot(facesContext, callerViewId, callerViewRoot);
if (callerViewRoot != null)
Modified: myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/config/FlowReturnAccept.java
URL: http://svn.apache.org/viewvc/myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/config/FlowReturnAccept.java?rev=796170&r1=796169&r2=796170&view=diff
==============================================================================
--- myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/config/FlowReturnAccept.java (original)
+++ myfaces/orchestra/trunk/flow/src/main/java/org/apache/myfaces/orchestra/flow/config/FlowReturnAccept.java Tue Jul 21 07:29:02 2009
@@ -140,7 +140,7 @@
* be used to transform the input parameter before it is assigned to dst.
* <p>
* Note that this EL expression is evaluated within the environment of the
- * called flow, not the caller.
+ * called flow, not the caller. TODO: This is currently never called!
*/
public String getConverter()
{