You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by "mawiesne (via GitHub)" <gi...@apache.org> on 2023/06/18 09:29:17 UTC

[GitHub] [opennlp] mawiesne opened a new pull request, #540: OPENNLP-1501 Make use of Records and Pattern Matching for instanceof

mawiesne opened a new pull request, #540:
URL: https://github.com/apache/opennlp/pull/540

   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OPENNLP-1501 Make use of Records and Pattern Matching for instanceof (opennlp)

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #540:
URL: https://github.com/apache/opennlp/pull/540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [opennlp] mawiesne commented on pull request #540: OPENNLP-1501 Make use of Records and Pattern Matching for instanceof

Posted by "mawiesne (via GitHub)" <gi...@apache.org>.
mawiesne commented on PR #540:
URL: https://github.com/apache/opennlp/pull/540#issuecomment-1596186246

   > we could re-add the Getters and mark them with @Deprecated(forRemoval=true) 
   
   I will update the PR for records which were public classes before to include the previous accessor methods, deprecated with "for removal" indicator on.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [opennlp] jzonthemtn commented on pull request #540: OPENNLP-1501 Make use of Records and Pattern Matching for instanceof

Posted by "jzonthemtn (via GitHub)" <gi...@apache.org>.
jzonthemtn commented on PR #540:
URL: https://github.com/apache/opennlp/pull/540#issuecomment-1596180560

   I like it, but I'm thinking about the potential impact on applications that use OpenNLP. For instance, will applications that use the `Tokens` class have to update their source to use `tokens.tokens()` instead of `tokens.getTokens()`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] OPENNLP-1501 Make use of Records and Pattern Matching for instanceof (opennlp)

Posted by "jzonthemtn (via GitHub)" <gi...@apache.org>.
jzonthemtn commented on PR #540:
URL: https://github.com/apache/opennlp/pull/540#issuecomment-1620205255

   > > we could re-add the Getters and mark them with @deprecated(forRemoval=true)
   > 
   > I will update the PR for records which were _public_ classes before including the previous accessor methods, deprecated with "for removal" indicator on.
   
   Looks great. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [opennlp] rzo1 commented on pull request #540: OPENNLP-1501 Make use of Records and Pattern Matching for instanceof

Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #540:
URL: https://github.com/apache/opennlp/pull/540#issuecomment-1596181985

   Yup. It is a breaking API change in its current form. If we want to retain compatibility, we could re-add the Getters and mark them with `@Deprecated(forRemoval=true)`, so ppl can adjust before we break them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org