[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12493: [Refactor] Migrate all workergroup-related interface functions from ProcessServiceImpl

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #12493:
URL: https://github.com/apache/dolphinscheduler/pull/12493#discussion_r1004046575


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkerGroupServiceImpl.java:
##########
@@ -354,4 +364,33 @@ public Map<String, Object> getWorkerAddressList() {
         return result;
     }
 
+    @Override
+    public String getTaskWorkerGroup(TaskInstance taskInstance) {
+        if (taskInstance == null) {
+            return null;
+        }
+
+        String workerGroup = taskInstance.getWorkerGroup();
+
+        if (!Strings.isNullOrEmpty(workerGroup)) {

Review Comment:
   ```suggestion
           if (StringUtils.isNotEmpty(workerGroup)) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org