You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/06/08 23:15:52 UTC

Review Request: String instantiation is not needed

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11750/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

Removed a String instntiation, test case added


Diffs
-----

  utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 
  utils/test/com/cloud/utils/net/NetUtilsTest.java 16d3402 

Diff: https://reviews.apache.org/r/11750/diff/


Testing
-------

Test included


Thanks,

Laszlo Hornyak

Re: Review Request: String instantiation is not needed

Posted by Chip Childers <ch...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11750/#review21997
-----------------------------------------------------------

Ship it!


Applied to master: 564013bec0d4356232d93ac52a3e44638578bff0

Thanks for the patch!

- Chip Childers


On June 8, 2013, 9:15 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11750/
> -----------------------------------------------------------
> 
> (Updated June 8, 2013, 9:15 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removed a String instntiation, test case added
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 
>   utils/test/com/cloud/utils/net/NetUtilsTest.java 16d3402 
> 
> Diff: https://reviews.apache.org/r/11750/diff/
> 
> 
> Testing
> -------
> 
> Test included
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>