You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alekseyolg (via GitHub)" <gi...@apache.org> on 2023/06/24 19:02:44 UTC

[GitHub] [superset] alekseyolg opened a new pull request, #24507: docker (build) without DOCKER_BUILDKIT

alekseyolg opened a new pull request, #24507:
URL: https://github.com/apache/superset/pull/24507

   According to https://github.com/apache/superset/pull/24504 if you remove DOCKER_BUILDKIT=1 then this should not affect the build process
   
   TESTING INSTRUCTIONS
   Manually build from the Dockerfile,
   
   docker build -t superset 
   
   And the build should finish without error.
   
   Successfully tagged superset:latest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] alekseyolg closed pull request #24507: docker (build) without DOCKER_BUILDKIT

Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg closed pull request #24507: docker (build) without DOCKER_BUILDKIT
URL: https://github.com/apache/superset/pull/24507


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] alekseyolg commented on pull request #24507: docker (build) without DOCKER_BUILDKIT

Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24507:
URL: https://github.com/apache/superset/pull/24507#issuecomment-1607425491

   Since this idea was not working - I close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] alekseyolg commented on pull request #24507: docker (build) without DOCKER_BUILDKIT

Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24507:
URL: https://github.com/apache/superset/pull/24507#issuecomment-1605700827

   @sebastianliebscher I tried creating a test pull request with your suggestion, but it failed on build
   
   https://github.com/apache/superset/actions/runs/5365790263/jobs/9734827799?pr=24507
   
   Apparently, this option is still necessary for the build (but if you believe your links, everything should work successfully).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sebastianliebscher commented on pull request #24507: docker (build) without DOCKER_BUILDKIT

Posted by "sebastianliebscher (via GitHub)" <gi...@apache.org>.
sebastianliebscher commented on PR #24507:
URL: https://github.com/apache/superset/pull/24507#issuecomment-1605692946

   Can you also remove unnecessary `DOCKER_BUILDKIT=1` introduced in https://github.com/apache/superset/pull/24504
   
   https://github.com/apache/superset/pull/24504/files#diff-e1276b2a2c85f7fb3b628b7acadbc417edb788f2848624f5f8180837bb3f1c53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] alekseyolg commented on pull request #24507: docker (build) without DOCKER_BUILDKIT

Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #24507:
URL: https://github.com/apache/superset/pull/24507#issuecomment-1607424479

   Since this idea was not working - I close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org