You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@velocity.apache.org by "Claude Brisson (JIRA)" <de...@velocity.apache.org> on 2007/11/16 17:11:43 UTC

[jira] Resolved: (VELOCITY-570) speed improvement of the tokenizer

     [ https://issues.apache.org/jira/browse/VELOCITY-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claude Brisson resolved VELOCITY-570.
-------------------------------------

    Resolution: Fixed

Thank you very much!
Patch reviewed, looks perfect.
Applied.


> speed improvement of the tokenizer
> ----------------------------------
>
>                 Key: VELOCITY-570
>                 URL: https://issues.apache.org/jira/browse/VELOCITY-570
>             Project: Velocity
>          Issue Type: Bug
>          Components: Engine
>    Affects Versions: 1.4, 1.5, 1.6
>         Environment: Tested on FreeBSD 6.2-STABLE and Linux (Debian Etch) on i386.
> Java: JDK 1.5
>            Reporter: Ronald Klop
>             Fix For: 1.6
>
>         Attachments: expandbuff-speedup.patch
>
>
> On some large templates (1-4MB) velocity gets very slow. I used JProfiler and found a lot of time is spent in VelocityCharStream.ExpandBuff. It is doing a lot of System.arraycopy.
> The problem is that the size of the buffer is increased linearly in stead of exponentialy.
> I have made a patch which doubles the size of the buffer in stead of incrementing it with the same value.
> In my tests and in JProfiler it is shown that a lot less time is spent in ExpandBuff.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@velocity.apache.org
For additional commands, e-mail: dev-help@velocity.apache.org