You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2023/03/22 02:44:58 UTC

[GitHub] [spark] ueshin opened a new pull request, #40514: [SPARK-41233][CONNECT][PYTHON] Add array_prepend to Spark Connect Python client

ueshin opened a new pull request, #40514:
URL: https://github.com/apache/spark/pull/40514

   ### What changes were proposed in this pull request?
   
   This is a follow-up of #38947.
   
   Add `array_prepend` function to Spark Connect Python client.
   
   ### Why are the changes needed?
   
   `array_prepend` was added at #38947 without Spark Connect Python client.
   
   ### Does this PR introduce _any_ user-facing change?
   
   `array_prepend`  will be available in Spark Connect Python client.
   
   ### How was this patch tested?
   
   Enabled the related test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #40514: [SPARK-41233][CONNECT][PYTHON] Add array_prepend to Spark Connect Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #40514: [SPARK-41233][CONNECT][PYTHON] Add array_prepend to Spark Connect Python client
URL: https://github.com/apache/spark/pull/40514


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] zhengruifeng commented on pull request #40514: [SPARK-41233][CONNECT][PYTHON] Add array_prepend to Spark Connect Python client

Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #40514:
URL: https://github.com/apache/spark/pull/40514#issuecomment-1478884594

   would you mind adding a simple test here? 
   https://github.com/apache/spark/blob/149e020a5ca88b2db9c56a9d48e0c1c896b57069/python/pyspark/sql/tests/connect/test_connect_function.py#L1077-L1089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #40514: [SPARK-41233][CONNECT][PYTHON] Add array_prepend to Spark Connect Python client

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #40514:
URL: https://github.com/apache/spark/pull/40514#issuecomment-1479016249

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org