[GitHub] sijie closed pull request #145: BOOKKEEPER-1057: Do not log error message after read failure in PendingReadOp

[GitBox <gi...@apache.org>]

sijie closed pull request #145: BOOKKEEPER-1057: Do not log error message after read failure in PendingReadOp
URL: https://github.com/apache/bookkeeper/pull/145
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
index cafe8f716..a14e39eab 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
@@ -389,8 +389,10 @@ private void submitCallback(int code) {
                     break;
                 }
             }
-            LOG.error("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First unread entry is {}",
-                    new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts, firstUnread });
+            if (LOG.isDebugEnabled()) {
+                LOG.debug("Read of ledger entry failed: L{} E{}-E{}, Heard from {}. First unread entry is {}",
+                        new Object[] { lh.getId(), startEntryId, endEntryId, heardFromHosts, firstUnread });
+            }
             readOpLogger.registerFailedEvent(latencyNanos, TimeUnit.NANOSECONDS);
         } else {
             readOpLogger.registerSuccessfulEvent(latencyNanos, TimeUnit.NANOSECONDS);


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services