You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/17 10:03:33 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Pearl1594 opened a new pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548
Add storage policies field for DiskOffering and Primary storage creation Forms
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-660061860
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#discussion_r467838257
##########
File path: src/views/infra/AddPrimaryStorage.vue
##########
@@ -475,8 +485,22 @@ export default {
Object.keys(smbParams).forEach((key, index) => {
params['details[' + index.toString() + '].' + key] = smbParams[key]
})
- } else if (values.protocol === 'PreSetup') {
+ } else if (values.protocol === 'PreSetup' && values.hypervisor !== 'VMware') {
url = this.presetupURL(server, path)
+ } else if (values.protocol === 'PreSetup' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.presetupURL('dummy', path)
+ } else if (values.protocol === 'datastorecluster' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.datastoreclusterURL('dummy', path)
Review comment:
@harikrishna-patnala I think you looking at an older commit, it's already been addressed in: https://github.com/apache/cloudstack-primate/pull/548/commits/0e86b9a9595281fad39c81c2cdea055c33229e98
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-668473363
@Pearl1594 cc @davidjumani is this ready for testing/merging?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-672612750
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/548 (JID-3078)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] harikrishna-patnala commented on a change in pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#discussion_r465492758
##########
File path: src/views/infra/AddPrimaryStorage.vue
##########
@@ -475,8 +485,22 @@ export default {
Object.keys(smbParams).forEach((key, index) => {
params['details[' + index.toString() + '].' + key] = smbParams[key]
})
- } else if (values.protocol === 'PreSetup') {
+ } else if (values.protocol === 'PreSetup' && values.hypervisor !== 'VMware') {
url = this.presetupURL(server, path)
+ } else if (values.protocol === 'PreSetup' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.presetupURL('dummy', path)
+ } else if (values.protocol === 'datastorecluster' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.datastoreclusterURL('dummy', path)
Review comment:
Same here, Please use variable 'server' instead of dummy value.
##########
File path: src/views/infra/AddPrimaryStorage.vue
##########
@@ -475,8 +485,22 @@ export default {
Object.keys(smbParams).forEach((key, index) => {
params['details[' + index.toString() + '].' + key] = smbParams[key]
})
- } else if (values.protocol === 'PreSetup') {
+ } else if (values.protocol === 'PreSetup' && values.hypervisor !== 'VMware') {
url = this.presetupURL(server, path)
+ } else if (values.protocol === 'PreSetup' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.presetupURL('dummy', path)
Review comment:
Please use variable 'server' instead of dummy value. I think this is an existing code but let's change it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-668502814
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-660065458
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/548 (JID-2407)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671321945
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/548 (JID-3023)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-668502962
@harikrishna-patnala could you please review the changes made. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671295870
@davidjumani can you review and advise if this is ready for merging?
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671317577
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671317824
@Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-672601201
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-660061503
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-672600075
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] harikrishna-patnala commented on a change in pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on a change in pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#discussion_r467841338
##########
File path: src/views/infra/AddPrimaryStorage.vue
##########
@@ -475,8 +485,22 @@ export default {
Object.keys(smbParams).forEach((key, index) => {
params['details[' + index.toString() + '].' + key] = smbParams[key]
})
- } else if (values.protocol === 'PreSetup') {
+ } else if (values.protocol === 'PreSetup' && values.hypervisor !== 'VMware') {
url = this.presetupURL(server, path)
+ } else if (values.protocol === 'PreSetup' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.presetupURL('dummy', path)
Review comment:
Yes @Pearl1594, I've checked the recent changes and LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671296834
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-671296739
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#issuecomment-668474834
@rhtyd this PR is wrt vsphere Advanced capabilities feature. Another form (Compute offering form) needs to be edited as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on a change in pull request #548: Add storage policies field for DiskOffering and Primary storage creation Forms
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #548:
URL: https://github.com/apache/cloudstack-primate/pull/548#discussion_r467838331
##########
File path: src/views/infra/AddPrimaryStorage.vue
##########
@@ -475,8 +485,22 @@ export default {
Object.keys(smbParams).forEach((key, index) => {
params['details[' + index.toString() + '].' + key] = smbParams[key]
})
- } else if (values.protocol === 'PreSetup') {
+ } else if (values.protocol === 'PreSetup' && values.hypervisor !== 'VMware') {
url = this.presetupURL(server, path)
+ } else if (values.protocol === 'PreSetup' && values.hypervisor === 'VMware') {
+ path = values.vCenterDataCenter
+ if (path.substring(0, 1) !== '/') {
+ path = '/' + path
+ }
+ path += '/' + values.vCenterDataStore
+ url = this.presetupURL('dummy', path)
Review comment:
@harikrishna-patnala I think you looking at an older commit, it's already been addressed in: 0e86b9a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org