You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "nil68657 (via GitHub)" <gi...@apache.org> on 2026/10/11 21:34:15 UTC

[PR] GH-37875: [C++][Parquet] Preserve large_string/large_binary dictionary value type on read [arrow]

nil68657 opened a new pull request, #53259:
URL: https://github.com/apache/arrow/pull/53259

   ### Rationale for this change
   
   When the stored Arrow schema has dictionary<large_string> or
   dictionary<large_binary>, use that value type instead of the inferred
   narrow one. TransferDictionary already casts the decoded dictionary to
   the requested type.
   
   ### What changes are included in this PR?
   
   - `cpp/src/parquet/arrow/schema.cc`
   
   ### Are these changes tested?
   
   Yes. A regression test in `cpp/src/parquet/arrow/arrow_reader_writer_test.cc` fails without the change and passes with it; the surrounding test module/binary passes.
   
   ### Are there any user-facing changes?
   
   See the rationale above.
   
   ### Was AI used for this PR?
   
   This PR is a joint contribution from Nilanjan Chatterjee ([@nil68657](https://github.com/nil68657)) and Claude (Claude Opus 5.5, via Claude Code). Nilanjan chose the issue and directed the work; Claude reproduced the bug, wrote the fix, the test and this description.
   
   **PR code and description written by:**
   
   - [ ] Human
   - [x] AI
   
   **Reviewed before submission by:**
   
   - [ ] Human
   - [x] AI
   - [ ] Not reviewed
   
   * GitHub Issue: #37875
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-37875: [C++][Parquet] Preserve large_string/large_binary dictionary value type on read [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] closed pull request #53259: GH-37875: [C++][Parquet] Preserve large_string/large_binary dictionary value type on read
URL: https://github.com/apache/arrow/pull/53259


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-37875: [C++][Parquet] Preserve large_string/large_binary dictionary value type on read [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #53259:
URL: https://github.com/apache/arrow/pull/53259#issuecomment-6114057907

   :warning: GitHub issue #37875 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GH-37875: [C++][Parquet] Preserve large_string/large_binary dictionary value type on read [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #53259:
URL: https://github.com/apache/arrow/pull/53259#issuecomment-6114082119

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   **This pull request has been automatically closed because you currently have 5 open pull requests, which is more than the limit of 3.**
   
   Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without repository access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale.
   
   Once one of [your other open pull requests](https://github.com/apache/arrow/pulls/nil68657) has been merged or closed, you are welcome to reopen this one.
   
   See also:
   
     * [Contribution Guidelines - Limit on concurrent pull requests](https://arrow.apache.org/docs/dev/developers/bug_reports.html#pr-limit)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org