You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/10 19:54:29 UTC
[GitHub] [airflow] ashb opened a new pull request, #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"
ashb opened a new pull request, #28840:
URL: https://github.com/apache/airflow/pull/28840
Reverts apache/airflow#23650
No no no. That was there for a reason. By making this test pass you are encoding that the _wrong_ behaviour is good.
If you want to get rid of the xfail _DO NOT_ just do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28840:
URL: https://github.com/apache/airflow/pull/28840#issuecomment-1378036683
Right my bad on approving it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28840:
URL: https://github.com/apache/airflow/pull/28840#issuecomment-1378773033
Yeah. The comment you left was actually perfect. If only I read it when approving of course.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"
Posted by GitBox <gi...@apache.org>.
ashb commented on PR #28840:
URL: https://github.com/apache/airflow/pull/28840#issuecomment-1378602953
@potiuk Easy enough mistake to make. I wrote that test so I know what I was trying to capture/show.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #28840: Revert "Fixed test and remove pytest.mark.xfail for test_exc_tb"
Posted by GitBox <gi...@apache.org>.
kaxil merged PR #28840:
URL: https://github.com/apache/airflow/pull/28840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org