You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/12 03:20:19 UTC
[GitHub] [flink] ifndef-SleePy commented on a change in pull request #11347:
[FLINK-14971][checkpointing] Make all the non-IO operations in
CheckpointCoordinator single-threaded
ifndef-SleePy commented on a change in pull request #11347: [FLINK-14971][checkpointing] Make all the non-IO operations in CheckpointCoordinator single-threaded
URL: https://github.com/apache/flink/pull/11347#discussion_r391381769
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -588,8 +588,8 @@ private void startTriggeringCheckpoint(
final CompletableFuture<?> coordinatorCheckpointsComplete = pendingCheckpointCompletableFuture
.thenComposeAsync((pendingCheckpoint) ->
OperatorCoordinatorCheckpoints.triggerAndAcknowledgeAllCoordinatorCheckpointsWithCompletion(
- coordinatorsToCheckpoint, pendingCheckpoint, timer),
- timer);
+ coordinatorsToCheckpoint, pendingCheckpoint, mainThreadExecutor),
Review comment:
Oops, I just realize this commit includes some codes belongs the preceding commit. It's must caused by the conflict resolving. And yes, you are right. This commit could be squashed with the preceding one. I will do the squashing when all comments are addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services