You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/06/25 07:28:24 UTC

[jira] [Commented] (CURATOR-116) Ordering of delayed distributed queue is inconsistent

    [ https://issues.apache.org/jira/browse/CURATOR-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043053#comment-14043053 ] 

ASF GitHub Bot commented on CURATOR-116:
----------------------------------------

GitHub user cammckenzie opened a pull request:

    https://github.com/apache/curator/pull/13

    CURATOR-116 - Modified sorting of children to be deterministic.

    Modified sorting of children to be deterministic.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cammckenzie/curator CURATOR-116

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/curator/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 1103f476d84a53784377a96f8661bd9219e7412d
Author: Cameron McKenzie <ca...@unico.com.au>
Date:   2014-06-25T01:53:00Z

    CURATOR-116 - Modified sorting of children to be deterministic.

----


> Ordering of delayed distributed queue is inconsistent
> -----------------------------------------------------
>
>                 Key: CURATOR-116
>                 URL: https://issues.apache.org/jira/browse/CURATOR-116
>             Project: Apache Curator
>          Issue Type: Bug
>          Components: Recipes
>    Affects Versions: 2.5.0
>            Reporter: Cameron McKenzie
>            Priority: Minor
>              Labels: DelayedDistributedQueue, recipes
>
> The ordering in which elements in the delayed distributed queue are processed is inconsistent. Only elements that have reached their expiry time are processed, but their actual order is not deterministic due to the logic used for sorting. The current time is used during the sorting process, so if an element becomes ready for processing half way through the sort, the order is not deterministic.
> The current time should be determined at the start of the sort process, and this point in time used for all comparisons.
> I believe this is the root cause for CURATOR-115 also, but I cannot reproduce CURATOR-115, so I have raised this as a separate defect.



--
This message was sent by Atlassian JIRA
(v6.2#6252)