You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/08/14 15:40:13 UTC

Review Request 24699: Alerts: Add Ability to Invalidate Definition Hash For An Agent

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24699/
-----------------------------------------------------------

Review request for Ambari and Nate Cole.


Bugs: AMBARI-6860
    https://issues.apache.org/jira/browse/AMBARI-6860


Repository: ambari


Description
-------

Alert definition hash values for a given host need to be able to be invalidate when an alert definition changes. Since there is no association between definition and host, we need to use a series of lookups to determine what hosts would be affected.


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java f4439b8fd5b67a566ad58d52b6d772461e24f5eb 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java fd8210bafad4f19a14f53ee96212972ab9dc5c97 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 1f31c35d5feca7f76116f3d4368d3f82bff053cc 
  ambari-server/src/main/resources/properties.json b12a531a9b9e5ffcffd14a84e368cfb438db06bd 
  ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java c6e26e8e25478f5e5093b6f6926d0f585deb9a05 
  ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java 937417a4b332d66ff2648cb433b70c8aa653a570 

Diff: https://reviews.apache.org/r/24699/diff/


Testing
-------

mvn test clean


Thanks,

Jonathan Hurley


Re: Review Request 24699: Alerts: Add Ability to Invalidate Definition Hash For An Agent

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24699/#review50584
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Aug. 14, 2014, 9:40 a.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24699/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 9:40 a.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-6860
>     https://issues.apache.org/jira/browse/AMBARI-6860
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Alert definition hash values for a given host need to be able to be invalidate when an alert definition changes. Since there is no association between definition and host, we need to use a series of lookups to determine what hosts would be affected.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java f4439b8fd5b67a566ad58d52b6d772461e24f5eb 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProvider.java fd8210bafad4f19a14f53ee96212972ab9dc5c97 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 1f31c35d5feca7f76116f3d4368d3f82bff053cc 
>   ambari-server/src/main/resources/properties.json b12a531a9b9e5ffcffd14a84e368cfb438db06bd 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertDefinitionResourceProviderTest.java c6e26e8e25478f5e5093b6f6926d0f585deb9a05 
>   ambari-server/src/test/java/org/apache/ambari/server/state/alerts/AlertDefinitionHashTest.java 937417a4b332d66ff2648cb433b70c8aa653a570 
> 
> Diff: https://reviews.apache.org/r/24699/diff/
> 
> 
> Testing
> -------
> 
> mvn test clean
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>