You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2025/10/01 21:29:08 UTC
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23483
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Introduced typed getters in RowResult and RowwiseRowResult to support
reading array column values with validity handling. Made the needed
changes to RowwiseRowResult to correctly compute offsets for array type.
Added basic end-to-end testing. More testing to follow.
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
5 files changed, 282 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/1
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 5: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1924/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 02:30:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@682
PS5, Line 682: getArray
this method is never used, is it necessary?
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@700
PS5, Line 700: "Column (name: " + col.getName() + ", index: " + columnIndex + ") is not an array");
consider using String.format("Column (name: %s, index: %d) is not an array", col.getName(), columnIndex)); instead of concatenation
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@287
PS5, Line 287: // LE
what does LE stand for?
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@344
PS5, Line 344: "Column " + col.getName() + " is not varlen");
consider using String.format()
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Oct 2025 13:01:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@54
PS6, Line 54: for (int i = 0; i < n; i++) {
: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
: result[i] = view.getInt16(i);
: }
Instead of these very ineffective code path (involving creating a temporary object in every call to ArrayCellView.getInt16(idx)), is it possible to provide more streamlined access to the underlying data stored in memory, just wrapped into Java-native container? Did you explore such an alternative?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:53:39 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 2: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1914/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 00:57:56 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 8: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1946/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 22:49:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 16:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2025/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 20:10:17 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 9: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1949/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Oct 2025 01:10:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43
PS6, Line 43: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
> In this, yes the reason being avoid silently losing null information.
Why just not to put 0 in place of null elements? In other words, how would toNullableInt8Array() is going to work if it's about to output an array as well?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Oct 2025 00:13:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#14).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,233 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/14
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 21:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2052/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 15:55:59 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#11).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewUtil for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
8 files changed, 1,119 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/11
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 12: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1980/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 23:54:26 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 21: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 17:20:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 19:
Overall looks OK, but Gradle couldn't build the project.
There are also a few warnings, but at least please address build failure.
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 03:20:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 4: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1921/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 01:52:06 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 16: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2025/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 23:10:47 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@150
PS18, Line 150: int vlen = content.validityLength();
> Isn't this number of bytes? Meanwhile, the comparison at line 156 hints it
Ah, sorry -- please ignore this.
Whoops, I confused it with the other context, when validity is already a bitset :)
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 00:08:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#12).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewUtil for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,123 insertions(+), 58 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/12
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 12:
(4 comments)
Just a few comments, planning to post more tomorrow.
Thanks for revving this patch!
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@46
PS12, Line 46: ArrayCellView
I didn't spot this in prior review rounds, but does it make sense to make this class package-private?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@489
PS12, Line 489: Type type = col.getType();
nit: move this to come after if (col.isArray()) {...} clause?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@81
PS12, Line 81: if (column.isArray()) {
: // Arrays are varlen on wire (offset + length), same as STRING/BINARY/VARCHAR.
: previousSize = 16;
: } else {
: previousSize = column.getTypeSize();
: }
Is this needed as of PS12?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2172
PS12, Line 2172: @MasterServerConfig(flags = {
: "--cfile_support_arrays=true",
: })
I guess this isn't needed with http://gerrit.cloudera.org:8080/23479
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 06:33:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 12:
(10 comments)
High-level feedback items:
* I'd not expose ArrayCellView in the public API at all -- I don't see why it's necessary. If we provide access to the array's data via Java-style arrays of boxed types, it should be already enough in the scope of this changelist, I guess.
* Do you think should we also expose the data as unboxed Java arrays along with validity bitset/vector? I'm not advocating for adding the corresponding code in this particular changelist, but I'm just curious what you think about this. I guess one important consumer of the scanned data should be Spark bindings, and it will be clear what's needed there once trying to implement those.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@626
PS12, Line 626: assert arr != null;
Could you use proper Precondition instead of assert here?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@667
PS12, Line 667: tsArr
What if tsAttr == null?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@680
PS12, Line 680:
nit: add 'break' in 'default' as well? or that's prohibited by the style checker?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@775
PS12, Line 775: public final ArrayCellView getArray(int columnIndex)
Why do you want to expose ArrayCellView as a part of the public interface? Wouldn't it be enough to provide accessors that return Java arrays of corresponding types given column name or column index in a scanner's result row?
For the C++ code, we don't expose ArrayCellMetadataView as a part of the public client API. Instead, there is KuduArrayCellView, and the only purpose of its existence is providing access to array cell's data via already existing KuduScanBatch::RowPtr::direct_data() API (e.g., it's used by Impala). If not direct_data(), there wouldn't be KuduArrayCellView() at all.
With Java API, I don't see anything that resembles KuduScanBatch::RowPtr::direct_data(). Why to expose ArrayCellView in the Java API then? Remember: every part of public API is a liability -- it's necessary to support it in future releases and we cannot update it without making sure it stays backward-compatible.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@794
PS12, Line 794: /**
: * Convenience overload for {@link #getArray(int)} by column name.
: */
: public final ArrayCellView getArray(String columnName) {
: return getArray(this.schema.getColumnIndex(columnName));
: }
I don't think this should be a public method.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@845
PS12, Line 845: int precision = 0;
: int scale = 0;
: if (col.getTypeAttributes() != null) {
: precision = col.getTypeAttributes().getPrecision();
: scale = col.getTypeAttributes().getScale();
: }
: Type logicalType = col.getNestedTypeDescriptor().getArrayDescriptor().getElemType();
Why not to do this in ArrayCellViewUtil method implementation instead, passing there just 'col' and 'view'?
Also, what if that's VARCHAR() type? Where is the field 'size' attribute being passed then?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2235
PS12, Line 2235: if (i % 5 == 0) {
: session.flush();
: }
What is this for? There flush() call at line 2239 already.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2245
PS12, Line 2245: // Ensure deterministic order by sorting on the key column
: rowStrings.sort(Comparator.comparingInt(rowStr -> {
: int eq = rowStr.indexOf('=');
: int comma = rowStr.indexOf(',', eq);
: return Integer.parseInt(rowStr.substring(eq + 1, comma).trim());
: }));
I'm not sure I understand why this is necessary: scanTableToStrings() already sorts the result strings. The key column is the first one in the output, and there is just 10 rows, indexed from 0 to 9, so why to have this at all?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2311
PS12, Line 2311: if (intArr != null) {
Here and below: should there be an assert based on index of the row instead of 'if()' clause? What if every row results in null instead of the expected array?
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2314
PS12, Line 2314: }
Here and below: consider adding verification of the actual values retrieved. It shouldn't be that hard, given it's already done for the stringified results, right?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Oct 2025 04:37:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 10: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1971/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sun, 12 Oct 2025 23:32:46 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 10:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1971/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sun, 12 Oct 2025 23:20:58 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1914/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Oct 2025 23:48:13 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 3:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1917/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 01:12:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 14:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@75
PS13, Line 75: * <p>If no validity bitmap is present, this corresponds to the
: * underlying values vector length.</p>
> nit: I'm not sure this brings in more clarity, at least to me it looked a b
Removed it.
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java:
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@270
PS13, Line 270: } else if (precision <= 18) {
> nit: fix the indent?
Done
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@327
PS13, Line 327: rray.Int64Array: {
> nit: I'm not sure this will hold true since it depends on future implementa
Done
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 23:10:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 15:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2017/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 15
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 23:55:15 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#19).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,438 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/19
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 19: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2045/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 02:20:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1906/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Oct 2025 23:26:04 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 13: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1993/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 02:28:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 11:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1979/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 16:37:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43
PS6, Line 43: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
I'm not sure I understand this correctly: does this mean there isn't a way to get an array using this toInt8Array() if at least one element is NULL?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:50:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#6).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewUtil for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
7 files changed, 656 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/6
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 18: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2043/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 23:59:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 17:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@762
PS18, Line 762: protected byte[] getArrayBytes(int columnIndex) {
> nit: annotate as Nullable?
Done
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@841
PS18, Line 841: public final Object getArrayData(int columnIndex) {
> nit: annotate this method as Nullable?
Done
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@866
PS18, Line 866: public final Object getArrayData(String columnName) {
> nit: annotate this method as Nullable?
Done
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2440
PS18, Line 2440:
> Here and below: I guess the prevalent use case would be supplying null inst
Done
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 01:47:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 14:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/2007/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 23:55:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#18).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,374 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/18
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 17:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2032/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 06:04:45 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 5:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@682
PS5, Line 682: getArray
> this method is never used, is it necessary?
It is used in a few tests now.
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@700
PS5, Line 700: "Column (name: " + col.getName() + ", index: " + columnIndex + ") is not an array");
> consider using String.format("Column (name: %s, index: %d) is not an array"
Done
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@287
PS5, Line 287: // LE
> what does LE stand for?
Little Endian. Removed it as it is not needed.
http://gerrit.cloudera.org:8080/#/c/23483/5/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@344
PS5, Line 344: "Column " + col.getName() + " is not varlen");
> consider using String.format()
Done
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:02:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 7:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1941/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 19:56:03 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 5:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1924/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 5
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 02:15:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 4:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1921/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 4
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 01:12:34 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 8:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1946/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 8
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 22:18:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 21: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2052/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 17:14:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 18:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@762
PS18, Line 762: protected byte[] getArrayBytes(int columnIndex) {
nit: annotate as Nullable?
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@841
PS18, Line 841: public final Object getArrayData(int columnIndex) {
nit: annotate this method as Nullable?
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@866
PS18, Line 866: public final Object getArrayData(String columnName) {
nit: annotate this method as Nullable?
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2440
PS18, Line 2440: new boolean[0]
Here and below: I guess the prevalent use case would be supplying null instead of empty validity vector. Why bother creating an empty vector if it's possible to supply null, right?
In this context, I'd expect to see some coverage for null validity arrays as well. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 00:22:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 20:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2049/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 03:31:56 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 17: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2032/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 08:02:39 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 12:
(15 comments)
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@46
PS12, Line 46: ArrayCellView
> I didn't spot this in prior review rounds, but does it make sense to make t
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@489
PS12, Line 489: Type type = col.getType();
> nit: move this to come after if (col.isArray()) {...} clause?
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@626
PS12, Line 626: assert arr != null;
> Could you use proper Precondition instead of assert here?
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@667
PS12, Line 667: tsArr
> What if tsAttr == null?
It can’t be null because toTimestampArray() always allocates and returns a new Timestamp[], even for empty or all-null arrays.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@680
PS12, Line 680:
> nit: add 'break' in 'default' as well? or that's prohibited by the style c
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@775
PS12, Line 775: public final ArrayCellView getArray(int columnIndex)
> Why do you want to expose ArrayCellView as a part of the public interface?
Yes, agree with you. We can keep getArrayData() public and the users can access array elements though that method.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@794
PS12, Line 794: /**
: * Convenience overload for {@link #getArray(int)} by column name.
: */
: public final ArrayCellView getArray(String columnName) {
: return getArray(this.schema.getColumnIndex(columnName));
: }
> I don't think this should be a public method.
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java@845
PS12, Line 845: int precision = 0;
: int scale = 0;
: if (col.getTypeAttributes() != null) {
: precision = col.getTypeAttributes().getPrecision();
: scale = col.getTypeAttributes().getScale();
: }
: Type logicalType = col.getNestedTypeDescriptor().getArrayDescriptor().getElemType();
> Why not to do this in ArrayCellViewUtil method implementation instead, pass
Done.
We don't need check the size attribute for VARCHAR type during decoding. This is similar to the implementation we have for primitive VARCHAR type.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java@81
PS12, Line 81: if (column.isArray()) {
: // Arrays are varlen on wire (offset + length), same as STRING/BINARY/VARCHAR.
: previousSize = 16;
: } else {
: previousSize = column.getTypeSize();
: }
> Is this needed as of PS12?
Nope, not needed anymore. good catch.
http://gerrit.cloudera.org:8080/#/c/23483/10/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/10/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@59
PS10, Line 59: Boxed num
> very small nit (I don't want to be pedantic): if it's boxed then it's a ref
Fixed it.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2172
PS12, Line 2172: @MasterServerConfig(flags = {
: "--cfile_support_arrays=true",
: })
> I guess this isn't needed with http://gerrit.cloudera.org:8080/23479
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2235
PS12, Line 2235: if (i % 5 == 0) {
: session.flush();
: }
> What is this for? There flush() call at line 2239 already.
Multiple flushes to catch any potential bugs during client side serialization or encoding across multiple RPC calls.
We can get rid of it if you think it doesn't make sense but I don't see any harm in it :)
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2245
PS12, Line 2245: // Ensure deterministic order by sorting on the key column
: rowStrings.sort(Comparator.comparingInt(rowStr -> {
: int eq = rowStr.indexOf('=');
: int comma = rowStr.indexOf(',', eq);
: return Integer.parseInt(rowStr.substring(eq + 1, comma).trim());
: }));
> I'm not sure I understand why this is necessary: scanTableToStrings() alrea
Good catch, I think I added it in when I was writing 50 rows in earlier versions and forgot to remove this later on.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2311
PS12, Line 2311: if (intArr != null) {
> Here and below: should there be an assert based on index of the row instead
Done
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2314
PS12, Line 2314: }
> Here and below: consider adding verification of the actual values retrieved
Done
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 00:48:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43
PS6, Line 43: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
> I'm not sure I understand this correctly: does this mean there isn't a way
In this, yes the reason being avoid silently losing null information.
I was planning to add more methods like toNullableInt8Array() in followup patches so the caller is aware of the behavior. Let me know if you think it would make sense to add those in further revisions of this patch.
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@54
PS6, Line 54: for (int i = 0; i < n; i++) {
: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
: result[i] = view.getInt16(i);
: }
> Instead of these very ineffective code path (involving creating a temporary
Yes, I briefly explored it but since it was not straightforward I did not pursue it. I think I can address it in the followup patches to improve the performance.
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 20:04:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#9).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewUtil for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
7 files changed, 656 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/9
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/9/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/9/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@111
PS9, Line 111: public static boolean[] toBoolArray(ArrayCellView view) {
: int n = view.length();
: boolean[] result = new boolean[n];
: for (int i = 0; i < n; i++) {
: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
: result[i] = view.getBoolean(i);
: }
: return result;
: }
:
: // -------------------
: // Reference types
: // -------------------
:
: public static String[] toStringArray(ArrayCellView view) {
: int n = view.length();
: String[] result = new String[n];
: for (int i = 0; i < n; i++) {
: result[i] = view.isValid(i) ? view.getString(i) : null;
: }
: return result;
: }
From the API design standpoint, this isn't quite a consistent behavior across different types: some toXxxArray throws exceptions on null elements, some are not.
Since this implementation isn't CPU and memory efficient because of element-by-element copying anyway (especially knowing that there is flatbuffer introspection on every view.getXxx() call with XxxArray objects created), maybe these array-style getters should use boxed types for all the supported array types then?
At least, that would be consistent from the API standpoint, and practically usable, even if it's not efficient.
Otherwise, having this difference in behavior between, say, toBoolArray() and toStringArray() makes it inconsistent, while toXxxArray() methods that throw on NULL elements are practically unusable.
What do you think?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Oct 2025 00:46:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43
PS6, Line 43: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
> In this, yes the reason being avoid silently losing null information.
I'm not sure it makes sense to have such behavior on null elements there and introduce toNullableXxxArray in addition to what's there already.
How do you choose which one to use to fetch the data as an array? In other words, with current toXxxArray() interface, where to get information on validity of elements, at least to know that some of them are null, so it would be possible to decide whether to call toXxxArray() or toNullableXxxArray()? I guess this means all those getters are supposed to work as toNullableXxxArray(), because using toXxxArray() doesn't make much sense unless writing some ugly code with try-catch-rinse-repeat.
What do you think?
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@206
PS6, Line 206: if (!view.isValid(i)) {
: out[i] = null;
That's interesting -- here there isn't an exception, contrary to the behavior of toDoubleArray and alike.
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 Oct 2025 00:26:03 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 12:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1980/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 12
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 22:38:27 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/6/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@43
PS6, Line 43: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
> I'm not sure it makes sense to have such behavior on null elements there an
Yes, this is resolved in the latest patch. We return a boxed wrapper array (e.g., Integer[]) for all the arraytypes with null elements populated, if present.
http://gerrit.cloudera.org:8080/#/c/23483/9/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/9/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@111
PS9, Line 111: public static boolean[] toBoolArray(ArrayCellView view) {
: int n = view.length();
: boolean[] result = new boolean[n];
: for (int i = 0; i < n; i++) {
: if (!view.isValid(i)) {
: throw new IllegalStateException("Null element at " + i);
: }
: result[i] = view.getBoolean(i);
: }
: return result;
: }
:
: // -------------------
: // Reference types
: // -------------------
:
: public static String[] toStringArray(ArrayCellView view) {
: int n = view.length();
: String[] result = new String[n];
: for (int i = 0; i < n; i++) {
: result[i] = view.isValid(i) ? view.getString(i) : null;
: }
: return result;
: }
> From the API design standpoint, this isn't quite a consistent behavior acro
Thanks for the inputs, this is fixed and addressed in the latest patch
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sun, 12 Oct 2025 23:20:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 15: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2017/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 15
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Oct 2025 13:46:21 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 18:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2043/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 23:11:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 20:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/20//COMMIT_MSG
Commit Message:
PS20:
I think it's necessary to re-base this patch at least on top of https://github.com/apache/kudu/commit/ac505c986987e9079acf9cbd74d3ef56f728a94d
That's the patch where the provisions for empty/null validity bitset have appeared. Without them, there might be CHECK/DCHEK or just nullptr dereferencing with SIGSEGV because the prior/outdated conventions on the validity vector.
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 07:08:48 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1917/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 3
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 02 Oct 2025 01:03:54 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 9:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1949/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 9
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 23:49:30 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 13: Code-Review+1
(5 comments)
Overall looks OK to me, just a few nits.
As discussed, I'm going to take another look as you revv this patch: I guess there will be more crucial updates on the API itself.
Thanks a lot for working on this!
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@75
PS13, Line 75: * <p>If no validity bitmap is present, this corresponds to the
: * underlying values vector length.</p>
nit: I'm not sure this brings in more clarity, at least to me it looked a bit confusing
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java:
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@270
PS13, Line 270:
nit: fix the indent?
http://gerrit.cloudera.org:8080/#/c/23483/13/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java@327
PS13, Line 327: and (future) DECIMAL128 both use BinaryArray
nit: I'm not sure this will hold true since it depends on future implementation of INT128 support in flatbuffers, so I'd suggest refraining of future-looking statements like this
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2235
PS12, Line 2235: session.flush();
:
: //
> Multiple flushes to catch any potential bugs during client side serializati
This is one extra flush, not multiple given there are 10 rows total. As for serialization of array cells, it's done on per-element basis, and it isn't related to flushing data to the server side. From the other side, if there is a bug somewhere in flushing/sending out the data to the server, it would pop up elsewhere as well, and we have special test cases to cover that.
OK, if you want to keep it here, that's fine, but I don't see how it adds any value into this test scenario.
http://gerrit.cloudera.org:8080/#/c/23483/12/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@2314
PS12, Line 2314: }
> Done
Thank you for addressing this!
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 23:35:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 20: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/2049/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 20
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 05:14:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Reviewed-on: http://gerrit.cloudera.org:8080/23483
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,438 insertions(+), 69 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Abhishek Chennaka: Verified
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 22
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 16:
There is a test failure, most likely related to the changes in this patch:
There was 1 failure:
1) testArrayColumns(org.apache.kudu.client.TestKuduClient)
org.junit.ComparisonFailure: expected:<INT32 key=0, INT[]32[] int32_arr=NULL,...> but was:<INT32 key=0, INT[8[] int8_arr=NULL, BOOL[] bool_arr=NULL, BINARY[] binary_arr=NULL, INT]32[] int32_arr=NULL,...>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.apache.kudu.client.TestKuduClient.testArrayColumns(TestKuduClient.java:2288)
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 04:22:07 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#17).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,307 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/17
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 17
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 16:
Yes, addressed it. Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 06:00:09 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 14:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2007/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 14
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Oct 2025 23:10:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#16).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,230 insertions(+), 69 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/16
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 16
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 13:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1993/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Oct 2025 00:54:42 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 18:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
File java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java:
http://gerrit.cloudera.org:8080/#/c/23483/18/java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java@150
PS18, Line 150: int vlen = content.validityLength();
Isn't this number of bytes? Meanwhile, the comparison at line 156 hints it's being interpreted as number of bits -- this seems to be a bug, no?
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 18
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Oct 2025 23:57:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 19:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/2045/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 19
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 01:52:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 21: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 21
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 Oct 2025 17:13:23 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1906/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 01 Oct 2025 21:29:12 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#2).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Introduced typed getters in RowResult and RowwiseRowResult to support
reading array column values with validity handling. Made the needed
changes to RowwiseRowResult to correctly compute offsets for array type.
Added basic end-to-end testing. More testing to follow.
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
5 files changed, 282 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/2
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#10).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewUtil for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
A java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
8 files changed, 1,119 insertions(+), 55 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/10
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23483/10/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java:
http://gerrit.cloudera.org:8080/#/c/23483/10/java/kudu-client/src/main/java/org/apache/kudu/util/ArrayCellViewUtil.java@59
PS10, Line 59: Primitive
very small nit (I don't want to be pedantic): if it's boxed then it's a reference type not a primitive type :)
https://docs.oracle.com/javase/specs/jls/se8/html/jls-5.html#jls-5.1.7
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 10
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 07:07:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 11: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1979/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 11
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Oct 2025 18:12:14 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23483
to look at the new patch set (#13).
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
KUDU-1261 [Java] Add read support for Array Type
Added support utilities for array cell handling in Kudu client
- Introduced ArrayCellViewHelper for consistent array data access/printing
- Extended RowResult and RowwiseRowResult with array-aware getters
- Added unit tests in TestKuduClient and TestRowResult for empty/null arrays
- Updated ClientTestUtil helpers to support array column creation
Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
---
M java/config/spotbugs/excludeFilter.xml
M java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellView.java
A java/kudu-client/src/main/java/org/apache/kudu/client/ArrayCellViewHelper.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowResult.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RowwiseRowResult.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRowResult.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
9 files changed, 1,179 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/23483/13
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 13
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 6: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1938/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:41:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 7: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1941/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 7
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 20:15:20 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-1261 [Java] Add read support for Array Type
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23483 )
Change subject: KUDU-1261 [Java] Add read support for Array Type
......................................................................
Patch Set 6:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1938/
--
To view, visit http://gerrit.cloudera.org:8080/23483
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie26750cf540b0097c77e5454c1c1d20b3a194c52
Gerrit-Change-Number: 23483
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Oct 2025 18:03:57 +0000
Gerrit-HasComments: No