You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by David Mackey <td...@booleanhaiku.com> on 2013/09/05 09:24:26 UTC
Review Request 13988: libprocess: Remove duplicated definition of
gethostbyname2_r
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13988/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
When compiling on an Apple the gethostbyname2_r function is defined twice; once in libprocess/src/pid.cpp and once in stout/os.hpp. This patch removes the unnecessary definition from libprocess/src/pid.cpp.
Diffs
-----
3rdparty/libprocess/src/pid.cpp 8f32b08
Diff: https://reviews.apache.org/r/13988/diff/
Testing
-------
make clean; make check;
Thanks,
David Mackey
Re: Review Request 13988: libprocess: Remove duplicated definition of
gethostbyname2_r
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13988/#review25948
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 5, 2013, 7:24 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13988/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 7:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When compiling on an Apple the gethostbyname2_r function is defined twice; once in libprocess/src/pid.cpp and once in stout/os.hpp. This patch removes the unnecessary definition from libprocess/src/pid.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/pid.cpp 8f32b08
>
> Diff: https://reviews.apache.org/r/13988/diff/
>
>
> Testing
> -------
>
> make clean; make check;
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request 13988: libprocess: Remove duplicated definition of
gethostbyname2_r
Posted by Ben Mahler <be...@gmail.com>.
> On Sept. 23, 2013, 11:31 p.m., Ben Mahler wrote:
> > Ship It!
Please mark as submitted!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13988/#review26333
-----------------------------------------------------------
On Sept. 5, 2013, 7:24 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13988/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 7:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When compiling on an Apple the gethostbyname2_r function is defined twice; once in libprocess/src/pid.cpp and once in stout/os.hpp. This patch removes the unnecessary definition from libprocess/src/pid.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/pid.cpp 8f32b08
>
> Diff: https://reviews.apache.org/r/13988/diff/
>
>
> Testing
> -------
>
> make clean; make check;
>
>
> Thanks,
>
> David Mackey
>
>
Re: Review Request 13988: libprocess: Remove duplicated definition of
gethostbyname2_r
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13988/#review26333
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Sept. 5, 2013, 7:24 a.m., David Mackey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13988/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 7:24 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> When compiling on an Apple the gethostbyname2_r function is defined twice; once in libprocess/src/pid.cpp and once in stout/os.hpp. This patch removes the unnecessary definition from libprocess/src/pid.cpp.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/pid.cpp 8f32b08
>
> Diff: https://reviews.apache.org/r/13988/diff/
>
>
> Testing
> -------
>
> make clean; make check;
>
>
> Thanks,
>
> David Mackey
>
>