[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1351: MINIFICPP-1861 Fix cmake command generation in bootstrap.sh

[GitBox <gi...@apache.org>]

lordgamez commented on code in PR #1351:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1351#discussion_r898104763


##########
bstrp_functions.sh:
##########
@@ -26,26 +26,14 @@ get_cmake_version(){
   CMAKE_REVISION=$(echo "$CMAKE_VERSION" | cut -d. -f3)
 }
 
-add_option(){
-  eval "$1=$2"
-  OPTIONS+=("$1")
-  CMAKE_OPTIONS_ENABLED+=("$1:$3")
-  CMAKE_OPTIONS_DISABLED+=("$1:$4")
-}
-
-add_enabled_option(){
-  eval "$1=$2"
-  OPTIONS+=("$1")
-  CMAKE_OPTIONS_DISABLED+=("$1:$3")
-}
 add_cmake_option(){
   eval "$1=$2"
 }
 
-add_disabled_option(){
+add_option(){

Review Comment:
   Good idea, added in 828ae6d371e4ec88eb29b2cafbf701a7d8d89009



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org