You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "kerwin-zk (via GitHub)" <gi...@apache.org> on 2025/08/28 11:51:36 UTC
[PR] [VL] Support compiling gluten cpp independently [incubator-gluten]
kerwin-zk opened a new pull request, #10575:
URL: https://github.com/apache/incubator-gluten/pull/10575
## What changes are proposed in this pull request?
Currently, when using ```builddeps-veloxbe.sh``` to compile gluten cpp independently, it first fetches the velox code and installs related dependencies, so you can’t compile only gluten cpp even if velox has already been built. After this PR, running ```builddeps-veloxbe.sh <build_option> build_gluten_cpp``` will compile only Gluten cpp.
## How was this patch tested?
CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support independent Gluten CPP build [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #10575:
URL: https://github.com/apache/incubator-gluten/pull/10575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support independent Gluten CPP build [incubator-gluten]
Posted by "kerwin-zk (via GitHub)" <gi...@apache.org>.
kerwin-zk commented on code in PR #10575:
URL: https://github.com/apache/incubator-gluten/pull/10575#discussion_r2309565705
##########
dev/builddeps-veloxbe.sh:
##########
@@ -259,45 +259,51 @@ function build_velox_backend {
build_gluten_cpp
}
-(
- cd $GLUTEN_DIR/ep/build-velox/src
- ./get_velox.sh $VELOX_PARAMETER
-)
+function get_velox_code {
Review Comment:
@PHILO-HE done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support independent Gluten CPP build [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #10575:
URL: https://github.com/apache/incubator-gluten/pull/10575#issuecomment-3236252062
Will merge this pr today if no other comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Support independent Gluten CPP build [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on code in PR #10575:
URL: https://github.com/apache/incubator-gluten/pull/10575#discussion_r2309538346
##########
dev/builddeps-veloxbe.sh:
##########
@@ -259,45 +259,51 @@ function build_velox_backend {
build_gluten_cpp
}
-(
- cd $GLUTEN_DIR/ep/build-velox/src
- ./get_velox.sh $VELOX_PARAMETER
-)
+function get_velox_code {
Review Comment:
prefer a shorter name: `get_velox`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org