You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by jl...@apache.org on 2021/05/27 05:23:29 UTC
[incubator-pinot] branch add-annotation-in-TableConfigBuilder
created (now 16806f9)
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a change to branch add-annotation-in-TableConfigBuilder
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git.
at 16806f9 Add annotation for deprecated fields segmentPushType and segmentPushFrequency in TableConfigBuilder
This branch includes the following new commits:
new 16806f9 Add annotation for deprecated fields segmentPushType and segmentPushFrequency in TableConfigBuilder
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[incubator-pinot] 01/01: Add annotation for deprecated fields
segmentPushType and segmentPushFrequency in TableConfigBuilder
Posted by jl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch add-annotation-in-TableConfigBuilder
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
commit 16806f929382ecabbce79f120d3094fab0183fe0
Author: Jack Li(Analytics Engineering) <jl...@jlli-mn1.linkedin.biz>
AuthorDate: Wed May 26 22:22:58 2021 -0700
Add annotation for deprecated fields segmentPushType and segmentPushFrequency in TableConfigBuilder
---
.../spi/config/table/SegmentsValidationAndRetentionConfig.java | 4 ++--
.../org/apache/pinot/spi/utils/builder/TableConfigBuilder.java | 8 ++++++++
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java b/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
index 2738105..d67fe3e 100644
--- a/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/config/table/SegmentsValidationAndRetentionConfig.java
@@ -94,7 +94,7 @@ public class SegmentsValidationAndRetentionConfig extends BaseJsonConfig {
}
/**
- * @deprecated Use {@code segmentPushFrequency} from {@link IngestionConfig#getBatchIngestionConfig()}
+ * @deprecated Use {@code segmentIngestionFrequency} from {@link IngestionConfig#getBatchIngestionConfig()}
*/
public String getSegmentPushFrequency() {
return _segmentPushFrequency;
@@ -105,7 +105,7 @@ public class SegmentsValidationAndRetentionConfig extends BaseJsonConfig {
}
/**
- * @deprecated Use {@code segmentPushType} from {@link IngestionConfig#getBatchIngestionConfig()}
+ * @deprecated Use {@code segmentIngestionType} from {@link IngestionConfig#getBatchIngestionConfig()}
*/
public String getSegmentPushType() {
return _segmentPushType;
diff --git a/pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java b/pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java
index 3e65c9a..0e025dc 100644
--- a/pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java
+++ b/pinot-spi/src/main/java/org/apache/pinot/spi/utils/builder/TableConfigBuilder.java
@@ -66,7 +66,9 @@ public class TableConfigBuilder {
private String _timeType;
private String _retentionTimeUnit;
private String _retentionTimeValue;
+ @Deprecated
private String _segmentPushFrequency;
+ @Deprecated
private String _segmentPushType = DEFAULT_SEGMENT_PUSH_TYPE;
private String _segmentAssignmentStrategy = DEFAULT_SEGMENT_ASSIGNMENT_STRATEGY;
private String _peerSegmentDownloadScheme;
@@ -160,6 +162,9 @@ public class TableConfigBuilder {
return this;
}
+ /**
+ * @deprecated Use {@code segmentIngestionType} from {@link IngestionConfig#getBatchIngestionConfig()}
+ */
public TableConfigBuilder setSegmentPushType(String segmentPushType) {
if (REFRESH_SEGMENT_PUSH_TYPE.equalsIgnoreCase(segmentPushType)) {
_segmentPushType = REFRESH_SEGMENT_PUSH_TYPE;
@@ -169,6 +174,9 @@ public class TableConfigBuilder {
return this;
}
+ /**
+ * @deprecated Use {@code segmentIngestionFrequency} from {@link IngestionConfig#getBatchIngestionConfig()}
+ */
public TableConfigBuilder setSegmentPushFrequency(String segmentPushFrequency) {
_segmentPushFrequency = segmentPushFrequency;
return this;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org