You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Stefan Bodewig (JIRA)" <ji...@apache.org> on 2009/01/30 16:16:59 UTC

[jira] Created: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

A few upstream (Ant) changes to the ZIP package
-----------------------------------------------

                 Key: SANDBOX-276
                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
             Project: Commons Sandbox
          Issue Type: Improvement
          Components: Compress
            Reporter: Stefan Bodewig
            Priority: Minor


I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.

http://svn.apache.org/viewvc?rev=738844&view=rev
use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.

http://svn.apache.org/viewvc?rev=738853&view=rev
make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559

http://svn.apache.org/viewvc?rev=739300&view=rev
skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940

There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.

Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670175#action_12670175 ] 

Torsten Curdt commented on SANDBOX-276:
---------------------------------------

Collaboration on this sounds like a good idea. In fact you are more than happy to commit the changes yourself if you like :)

> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: SANDBOX-276
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Compress
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Moved: (COMPRESS-39) A few upstream (Ant) changes to the ZIP package

Posted by "Dennis Lundberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COMPRESS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg moved SANDBOX-276 to COMPRESS-39:
-------------------------------------------------

    Component/s:     (was: Compress)
            Key: COMPRESS-39  (was: SANDBOX-276)
        Project: Commons Compress  (was: Commons Sandbox)

> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: COMPRESS-39
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-39
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670282#action_12670282 ] 

bodewig edited comment on SANDBOX-276 at 2/4/09 2:44 AM:
----------------------------------------------------------------

all three patches have been merged, the last one was svn revision 740657.

      was (Author: bodewig):
    all three patches have been merged.
  
> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: SANDBOX-276
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Compress
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (COMPRESS-39) A few upstream (Ant) changes to the ZIP package

Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COMPRESS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Torsten Curdt closed COMPRESS-39.
---------------------------------


> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: COMPRESS-39
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-39
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>             Fix For: 1.0
>
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670237#action_12670237 ] 

Stefan Bodewig commented on SANDBOX-276:
----------------------------------------

I hope you meant to say that you'd be happy for me to commit the stuff 8-)

I've committed the second and third patch since I'm unsure about the JDK baseline required by compress, I'll take this to the dev list.

Since I'm unsure about tracking policies in commons (again, I'll ask on list), the related svn revisions are 740604 and 740605.

> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: SANDBOX-276
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Compress
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SANDBOX-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig resolved SANDBOX-276.
------------------------------------

    Resolution: Fixed

all three patches have been merged.

> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: SANDBOX-276
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Compress
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SANDBOX-276) A few upstream (Ant) changes to the ZIP package

Posted by "Torsten Curdt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SANDBOX-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670175#action_12670175 ] 

tcurdt edited comment on SANDBOX-276 at 2/4/09 2:02 AM:
---------------------------------------------------------------

Collaboration on this sounds like a good idea. In fact you are more than welcome to commit the changes yourself if you like :)

      was (Author: tcurdt):
    Collaboration on this sounds like a good idea. In fact you are more than happy to commit the changes yourself if you like :)
  
> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: SANDBOX-276
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-276
>             Project: Commons Sandbox
>          Issue Type: Improvement
>          Components: Compress
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (COMPRESS-39) A few upstream (Ant) changes to the ZIP package

Posted by "Stefan Bodewig (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/COMPRESS-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Bodewig updated COMPRESS-39:
-----------------------------------

    Fix Version/s: 1.0

> A few upstream (Ant) changes to the ZIP package
> -----------------------------------------------
>
>                 Key: COMPRESS-39
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-39
>             Project: Commons Compress
>          Issue Type: Improvement
>            Reporter: Stefan Bodewig
>            Assignee: Torsten Curdt
>            Priority: Minor
>             Fix For: 1.0
>
>
> I've recently applied three patches to the Ant code base that may be of interest to commons-compress as well.
> http://svn.apache.org/viewvc?rev=738844&view=rev
> use more modern collections (since Ant trunk now officially is JDK 1.4+).  This results in some minor performance improvements because of less synchronization and a theoretical bigger improvement for entries with many extra fields.
> http://svn.apache.org/viewvc?rev=738853&view=rev
> make sure the archive is closed in the presence of a RuntimeExcepetion which may happen when LFH parsing fails.
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=46559
> http://svn.apache.org/viewvc?rev=739300&view=rev
> skip extra fields that don't follow the recommended HEADER-ID, LENGTH structure at the end of the extra field (this is what unzip does as well).
> Fixes https://issues.apache.org/bugzilla/show_bug.cgi?id=42940
> There are two more issues open in Ant's bugzilla I may be working on over the next few weeks (low prio for me):
> https://issues.apache.org/bugzilla/show_bug.cgi?id=46637 - which may be impossible to do in a backwards compatible way (not a concern for a sandbox component, I guess) and the more important https://issues.apache.org/bugzilla/show_bug.cgi?id=45429 which would allow archives to contain files bigger than 2 GB and support UTF8 filenames in a more portable way.
> Technically I am a commons committer, maybe we can collaborate on the required changes via the commons dev list (or Ant's).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.