You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/26 21:51:58 UTC

[jira] [Work logged] (TS-5006) Fix Coverity Issues

     [ https://issues.apache.org/jira/browse/TS-5006?focusedWorklogId=31132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31132 ]

ASF GitHub Bot logged work on TS-5006:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Oct/16 21:51
            Start Date: 26/Oct/16 21:51
    Worklog Time Spent: 10m 
      Work Description: Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1140#discussion_r85228363
  
    --- Diff: proxy/http/HttpSM.cc ---
    @@ -3309,7 +3309,7 @@ HttpSM::tunnel_handler_ua(int event, HttpTunnelConsumer *c)
     
         // only external POSTs should be subject to this logic; ruling out internal POSTs here
         bool is_eligible_post_request = (t_state.method == HTTP_WKSIDX_POST);
    -    if (is_eligible_post_request) {
    +    if (is_eligible_post_request && ua_session) {
    --- End diff --
    
    I don't know this code much, but seeing that we don't crash here, presumably ua_session generally is not NULL here. So maybe a better thing is a release assert?


Issue Time Tracking
-------------------

            Worklog Id:     (was: 31132)
            Time Spent: 10m
    Remaining Estimate: 0h

> Fix Coverity Issues
> -------------------
>
>                 Key: TS-5006
>                 URL: https://issues.apache.org/jira/browse/TS-5006
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Phil Sorber
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Issue to track coverity fixes



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)