You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/24 17:08:00 UTC
[jira] [Commented] (CB-13825) Outdated node_modules
[ https://issues.apache.org/jira/browse/CB-13825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337900#comment-16337900 ]
ASF GitHub Bot commented on CB-13825:
-------------------------------------
albertolalama opened a new pull request #46: CB-13825: (osx) Update node dependencies
URL: https://github.com/apache/cordova-osx/pull/46
### Platforms affected
OSX
### What does this PR do?
Updates node_modules by running `npm install --only=production` in order to fix a bug that prevented plugins from being installed/removed.
### What testing has been done on this change?
Plugin management by pinning cordova-osx to this branch.
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Outdated node_modules
> ---------------------
>
> Key: CB-13825
> URL: https://issues.apache.org/jira/browse/CB-13825
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-osx
> Affects Versions: 4.1.0
> Reporter: Alberto Lalama
> Assignee: Tobias Bocanegra
> Priority: Major
>
> Commit [f7db769af|https://github.com/apache/cordova-osx/pull/43] updated cordova-common to v2.1.0 without updating node_modules. This means that pinning cordova-osx to the github repo in config.xml fails to install plugins with the following error:
> Installing "cordova-plugin-whitelist" for osx
> Failed to install 'cordova-plugin-whitelist':TypeError: Cannot read property 'get' of undefined
> at Api.addPlugin (platforms/osx/cordova/Api.js:187:25)
> at handleInstall (cordova-lib/src/plugman/install.js:611:6)
> at node_modules/cordova-lib/src/plugman/install.js:407:28
> at _fulfilled (node_modules/cordova-lib/node_modules/q/q.js:787:54)
> at self.promiseDispatch.done (node_modules/cordova-lib/node_modules/q/q.js:816:30)
> at Promise.promise.promiseDispatch (node_modules/cordova-lib/node_modules/q/q.js:749:13)
> at node_modules/cordova-lib/node_modules/q/q.js:509:49
> at flush (node_modules/cordova-lib/node_modules/q/q.js:108:17)
> at _combinedTickCallback (internal/process/next_tick.js:131:7)
> at process._tickCallback (internal/process/next_tick.js:180:9)
> Failed to restore plugin "cordova-plugin-whitelist" from config.xml. You might need to try adding it again. Error: TypeError: Cannot read property 'get' of undefined
>
> A straightforward solution would be to update node_modules (cordova-ios seems to do this regularly). Could we use a dependency manager (e.g. yarn)? Any other suggestions?
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org