You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2017/03/02 22:32:46 UTC
Review Request 57258: AMBARI-20279. HiveServerInteractive. Set value
for
"num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Bugs: AMBARI-20279
https://issues.apache.org/jira/browse/AMBARI-20279
Repository: ambari
Description
-------
Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, there can be a scenario where "num_llap_nodes_for_llap_daemons" doesnt exist in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with HDP 2.5) to Ambari 2.5.
**Fix:** Set this config in SA only if it present in hive-interactive-env.
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 3629f30
ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
Diff: https://reviews.apache.org/r/57258/diff/1/
Testing
-------
Thanks,
Swapan Shridhar
Re: Review Request 57258: AMBARI-20279. HiveServerInteractive. Set
value for
"num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/#review167776
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On March 2, 2017, 10:32 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57258/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20279
> https://issues.apache.org/jira/browse/AMBARI-20279
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, there can be a scenario where "num_llap_nodes_for_llap_daemons" doesnt exist in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with HDP 2.5) to Ambari 2.5.
>
> **Fix:** Set this config in SA only if it present in hive-interactive-env.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 3629f30
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
>
>
> Diff: https://reviews.apache.org/r/57258/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 57258: AMBARI-20279. HiveServerInteractive. Set
value for
"num_llap_nodes_for_llap_daemons" only if it exists in hive-interactive-site.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57258/#review167756
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 2, 2017, 10:32 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57258/
> -----------------------------------------------------------
>
> (Updated March 2, 2017, 10:32 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-20279
> https://issues.apache.org/jira/browse/AMBARI-20279
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Given that "num_llap_nodes_for_llap_daemons" only exists in 2.6 HDP stack, there can be a scenario where "num_llap_nodes_for_llap_daemons" doesnt exist in hive-interactive-site. This can happen if we upgrade from Ambari 2.4 (with HDP 2.5) to Ambari 2.5.
>
> **Fix:** Set this config in SA only if it present in hive-interactive-env.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py 3629f30
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py a450d4d
> ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 2d7bcd3
>
>
> Diff: https://reviews.apache.org/r/57258/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapan Shridhar
>
>