You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/14 12:59:17 UTC

[GitHub] [airflow] ashb opened a new pull request #18240: Fix DB session handling in XCom.set.

ashb opened a new pull request #18240:
URL: https://github.com/apache/airflow/pull/18240

Since the function has the `@provide_session` decorator it should not be
committing the session (the decorator handles that if it's not passed a
session) and nor should it be calling expunge_all -- that detaches all
objects from the session which is just not needed (or right) behaviour
form setting an XCom value.

By using the `session` fixture we get the transaction automatically
rolled back, so we don't need any setup/teardown methods.

(This is a prep PR for fixing the deserialize behavoiur of XCom.get_one)

<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.

Feel free to ping committers for the review!

In case of existing issue, reference it using one of the following:

closes: #ISSUE
related: #ISSUE

How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->

---
**^ Add meaningful description above**

Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr commented on pull request #18240: Fix DB session handling in XCom.set.

Posted by GitBox <gi...@apache.org>.

uranusjr commented on pull request #18240:
URL: https://github.com/apache/airflow/pull/18240#issuecomment-919734440


   Are even the `flush`es needed?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb merged pull request #18240: Fix DB session handling in XCom.set.

Posted by GitBox <gi...@apache.org>.

ashb merged pull request #18240:
URL: https://github.com/apache/airflow/pull/18240


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #18240: Fix DB session handling in XCom.set.

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on pull request #18240:
URL: https://github.com/apache/airflow/pull/18240#issuecomment-919735178


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] uranusjr closed pull request #18240: Fix DB session handling in XCom.set.

Posted by GitBox <gi...@apache.org>.

uranusjr closed pull request #18240:
URL: https://github.com/apache/airflow/pull/18240


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on pull request #18240: Fix DB session handling in XCom.set.

Posted by GitBox <gi...@apache.org>.

ashb commented on pull request #18240:
URL: https://github.com/apache/airflow/pull/18240#issuecomment-919861593


   > Are even the `flush`es needed?
   
   Possibly not striclty needed, but its hard to reason about where this might be used, so a flush is safer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org