You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/08 23:10:52 UTC
[GitHub] [superset] diegomedina248 opened a new pull request, #21019: fix: Unable to sync columns when dataset name has '+'
diegomedina248 opened a new pull request, #21019:
URL: https://github.com/apache/superset/pull/21019
### SUMMARY
When editing a dataset, attempting to sync columns from source might fail if the dataset name has special character.
The table name is sent as a query param to the API and it's not properly encoded.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
https://user-images.githubusercontent.com/17252075/183529728-5d99e05f-468a-4e6b-849d-daed8706bb1e.mov
After:
https://user-images.githubusercontent.com/17252075/183529482-00b7cbf0-58a9-4172-8e9d-2b026f6c72ed.mov
### TESTING INSTRUCTIONS
1. Create a dataset with name “Vehicle Sales +”
2. Edit the dataset
3. Navigate to columns
4. Click on SYNC COLUMNS FROM SOURCE
5. Will get error message: Dataset does not exist
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21019: fix: Unable to sync columns when dataset name has '+'
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21019:
URL: https://github.com/apache/superset/pull/21019#issuecomment-1208738876
# [Codecov](https://codecov.io/gh/apache/superset/pull/21019?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21019](https://codecov.io/gh/apache/superset/pull/21019?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6fcadc6) into [master](https://codecov.io/gh/apache/superset/commit/846529a5009cd1ae817e9deeda2c687c6ed597d7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (846529a) will **increase** coverage by `0.00%`.
> The diff coverage is `94.11%`.
> :exclamation: Current head 6fcadc6 differs from pull request most recent head 20ed9e2. Consider uploading reports for the commit 20ed9e2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #21019 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1767 1767
Lines 67335 67349 +14
Branches 7144 7145 +1
=======================================
+ Hits 44678 44691 +13
Misses 20829 20829
- Partials 1828 1829 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.11% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21019?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...end/src/components/Datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/21019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YXNvdXJjZS9EYXRhc291cmNlRWRpdG9yLmpzeA==) | `65.61% <0.00%> (-0.27%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/21019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.32% <100.00%> (-0.01%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/21019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `88.43% <100.00%> (+0.23%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/21019/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.75% <100.00%> (+0.05%)` | :arrow_up: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #21019: fix: Unable to sync columns when dataset name has '+'
Posted by GitBox <gi...@apache.org>.
rusackas merged PR #21019:
URL: https://github.com/apache/superset/pull/21019
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #21019: fix: Unable to sync columns when dataset name has '+'
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #21019:
URL: https://github.com/apache/superset/pull/21019#issuecomment-1216144166
Re-running E2E tests, hoping to merge if they make it! 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org