[GitHub] haukepetersen commented on a change in pull request #137: porting: Use real function pointer types for ISR functions

[GitBox <gi...@apache.org>]

haukepetersen commented on a change in pull request #137: porting: Use real function pointer types for ISR functions
URL: https://github.com/apache/mynewt-nimble/pull/137#discussion_r226294073
 
 

 ##########
 File path: nimble/include/nimble/nimble_npl.h
 ##########
 @@ -157,7 +157,7 @@ void ble_npl_time_delay(ble_npl_time_t ticks);
 
 #if NIMBLE_CFG_CONTROLLER
 
-void ble_npl_hw_set_isr(int irqn, uint32_t addr);
+void ble_npl_hw_set_isr(int irqn, void (*addr)());
 
 Review comment:
   This triggers a `[-Werror=strict-prototypes]` when building for RIOT. 
   
   Using instead
   ```c
   void ble_npl_hw_set_isr(int irqn, void (*addr)(void));
   ```
   fixes that issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services